Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add giabalanai keyboard #10125

Merged
merged 133 commits into from
Aug 31, 2022
Merged

Add giabalanai keyboard #10125

merged 133 commits into from
Aug 31, 2022

Conversation

3araht
Copy link
Contributor

@3araht 3araht commented Aug 21, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • A new keyboard layout for Chromatic Accordion MIDI KEYBOARD (C-System)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Aug 22, 2020 •
edited
Loading

I've unchecked your description for the "PR Checklist" item -- please run through the PR Checklist document and make any necessary changes.

@tzarc tzarc requested a review from a team August 22, 2020 01:47
@tzarc tzarc added keyboard pr_checklist_pending Needs changes as per the PR checklist labels Aug 22, 2020
@3araht
PR checklist reviewed.
d1280de 
default keymap simplified and 3araht keymap added.
@3araht
Copy link
Contributor Author

3araht commented Aug 23, 2020

Thank you for your feedback.
I checked the PR checklist again and amended as much as possible.

Regarding the topic below:

rules.mk

  • removed MIDI_ENABLE, FAUXCLICKY_ENABLE and HD44780_ENABLE

Since this keyboard is mainly a MIDI keyboard, "MIDI_ENABLE" has to be enabled.
I found a few keyboards in "qmk_firmware/keyboards/" that "MIDI_ENABLE" is enabled.

Can this be relaxed as well?

Or maybe something else has to be updated.
If so, could you help me out?

Thank you in advance!

fauxpark
fauxpark requested changes Aug 23, 2020
View reviewed changes
keyboards/giabalanai/giabalanai.c Outdated Show resolved Hide resolved
keyboards/giabalanai/config.h Outdated Show resolved Hide resolved
keyboards/giabalanai/rules.mk Show resolved Hide resolved
keyboards/giabalanai/rules.mk Outdated Show resolved Hide resolved
keyboards/giabalanai/rules.mk Outdated Show resolved Hide resolved
keyboards/giabalanai/config.h Outdated Show resolved Hide resolved
keyboards/giabalanai/keymaps/3araht/keymap.c Outdated Show resolved Hide resolved
keyboards/giabalanai/keymaps/3araht/keymap.c Outdated Show resolved Hide resolved
keyboards/giabalanai/keymaps/3araht/keymap.c Outdated Show resolved Hide resolved
keyboards/giabalanai/keymaps/3araht/keymap.c Outdated Show resolved Hide resolved
drashna
drashna reviewed Aug 24, 2020
View reviewed changes
keyboards/giabalanai/config.h Outdated Show resolved Hide resolved
keyboards/giabalanai/config.h Outdated Show resolved Hide resolved
keyboards/giabalanai/config.h Outdated Show resolved Hide resolved
keyboards/giabalanai/giabalanai.h Outdated Show resolved Hide resolved
keyboards/giabalanai/keymaps/3araht/keymap.c Outdated Show resolved Hide resolved
keyboards/giabalanai/readme.md Outdated Show resolved Hide resolved
keyboards/giabalanai/rules.mk Outdated Show resolved Hide resolved
3araht added 2 commits August 24, 2020 19:42
@3araht
suggestions applied.
3f11f85
@3araht
RGBLED_SPLIT tested but it didn't work well yet.
e483914 
Not sure but rgblight_sethsv_at() might not support RGBLED_SPLIT yet.
@3araht 3araht requested a review from fauxpark August 24, 2020 13:23
@3araht
Copy link
Contributor Author

3araht commented Sep 7, 2020 •
edited
Loading

The Travis CI build failed

Oh no... I can't get rid of lib/vusb.

error: pathspec 'lib/vusb' did not match any file(s) known to git

I did pulled the latest data by running below:

git pull qmk master

Maybe I should have checked out master beforehand but I didn't.
Is it why this happened?

Is there a way to bring it back to the record before I did "Merge branch 'master' of https://github.com/qmk/qmk_firmware into add… … 55a0bf5"?"

@3araht 3araht force-pushed the add_giabalanai_keyboard branch from 7571255 to 167f2e5 Compare August 29, 2022 11:46
@3araht 3araht mentioned this pull request Aug 31, 2022
Closed
14 tasks
@keyboard-magpie keyboard-magpie merged commit 1ccd0c1 into qmk:master Aug 31, 2022
@3araht 3araht deleted the add_giabalanai_keyboard branch September 1, 2022 12:05
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@3araht @nolanseaton
Add giabalanai keyboard (qmk#10125)
3de589a 
by 3araht
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
awaiting review keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3araht @tzarc @drashna @fauxpark @keyboard-magpie