Rename Doc/README.txt to Doc/README.rst #19

ghost · 2017-02-11T03:38:27Z

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

the-knights-who-say-ni · 2017-02-11T03:38:28Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

Sign the PSF contributor agreement
Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

methane · 2017-02-11T03:44:31Z

Doc/make.bat

@@ -74,7 +74,7 @@ echo.   Provided by this script:
 echo.      clean, check, serve, htmlview
 echo.
 echo.All arguments past the first one are passed through to sphinx-build as
-echo.filenames to build or are ignored.  See README.txt in this directory or
+echo.filenames to build or are ignored.  See README.rst in this directory or


Doc/README.txt is still alive.

This PR renames Doc/README.txt to Doc/README.rst.

Ah, I'm sorry. I misundersttod.

methane · 2017-02-11T03:46:31Z

Doc/make.bat

@@ -74,7 +74,7 @@ echo.   Provided by this script:
 echo.      clean, check, serve, htmlview
 echo.
 echo.All arguments past the first one are passed through to sphinx-build as
-echo.filenames to build or are ignored.  See README.txt in this directory or
+echo.filenames to build or are ignored.  See README.rst in this directory or


Ah, I'm sorry. I misundersttod.

methane · 2017-02-11T03:47:51Z

I think we don't require CLA sign for pull requests like this.

orsenthil · 2017-02-11T03:49:42Z

@methane , any patch / contribution requires CLA sign.

ghost · 2017-02-11T03:54:49Z

I signed it an hour ago.

methane · 2017-02-11T04:26:15Z

Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)

vstinner

I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.

ghost · 2017-02-12T22:23:23Z

@methane MY CLA still has not been marked, and I currently have this:

It's been two days since I submitted it, any update?

vstinner · 2017-02-12T22:29:02Z

Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch.

ghost · 2017-02-12T23:26:58Z

No, it was made in the master branch @Haypo

ghost · 2017-02-12T23:28:00Z

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

vstinner · 2017-02-13T00:00:03Z

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

Look at README.rst in the root directory.

vstinner

I suggested different text where [...] is the link.

vstinner · 2017-02-13T00:15:15Z

Doc/README.rst


 Bugs in the toolset should be reported in the Sphinx bug tracker at
-https://www.bitbucket.org/birkenfeld/sphinx/issues/.
+`bitbucket.org/birkenfeld/sphinx/issues/ <https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_.


I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."

vstinner · 2017-02-13T00:15:44Z

Doc/README.rst

@@ -109,10 +109,10 @@ Contributing
 ============

 Bugs in the content should be reported to the Python bug tracker at


"Bugs in the content should be reported to the [Python bug tracker]."

vstinner · 2017-02-13T00:16:39Z

Doc/README.rst

 used to build the docs.  It is not included in this tree, but maintained
-separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>.
+separately and available from `PyPI <https://pypi.python.org/pypi/Sphinx>`_.


and [available from PyPI].

vstinner · 2017-02-13T00:17:23Z

Doc/README.rst

@@ -3,19 +3,19 @@ Python Documentation README

 This directory contains the reStructuredText (reST) sources to the Python
 documentation.  You don't need to build them yourself, prebuilt versions are
-available at <https://docs.python.org/dev/download.html>.
+available at `docs.python.org/dev/download.html <https://docs.python.org/dev/download.html>`_.


..., [prebuilt versions are available].

ghost · 2017-02-13T00:29:12Z

The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is narayan<>roger<>@<>gmail.com (remove the <>)

codecov · 2017-02-13T01:02:44Z

Codecov Report

Merging #19 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289091   289089       -2     
- Misses      61857    61859       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29896ad...08cb2a3. Read the comment docs.

ghost · 2017-02-13T01:43:18Z

@Haypo The changes you requested were made

ghost · 2017-02-13T15:45:48Z

It is still not showing up on my account! I have filed a new one for each day it has not been added.

berkerpeksag · 2017-02-13T15:52:03Z

Please note that the PSF is based in the United States and they can only process CLA requests in workdays.

ghost · 2017-02-15T01:01:57Z

I am moving this PR soon now that my CLA is confirmed and due to overlaps with the master branch.

ghost · 2017-02-15T01:27:23Z

Moved to #104 and my CLA is now processed

Fix venvlauncher

…H-19) Closes python/miss-islington#18

19: Warn for range and xrange r=ltratt a=nanjekyejoannah See notes: ``` Py2.x: >>> x = xrange(1, 10000) >>> a = range(1,10000) >>> type(a) <type 'list'> >>> Py3.x: >>> x = xrange(1, 10000) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'xrange' is not defined >>> a = range(1,10000) >>> type(a) <class 'range'> >>> ``` Co-authored-by: Joannah Nanjekye <[email protected]>

* fix: off by one error in forward jump calculation * Test: fixed test for python#18 * test: remove broken test --------- Co-authored-by: Jules <[email protected]>

Roger added 3 commits February 10, 2017 22:36

Update Doc README.txt to README.rst

7eaa651

Update file reference

6aa6dc3

Update file reference

bc35d3d

the-knights-who-say-ni added the CLA not signed label Feb 11, 2017

methane approved these changes Feb 11, 2017

View reviewed changes

methane requested changes Feb 11, 2017

View reviewed changes

methane approved these changes Feb 11, 2017

View reviewed changes

methane mentioned this pull request Feb 11, 2017

Update link destination of the Mersenne Twister homepage #20

Merged

berkerpeksag added the backport to 3.6 label Feb 11, 2017

vstinner requested changes Feb 12, 2017

View reviewed changes

vstinner removed the CLA not signed label Feb 12, 2017

the-knights-who-say-ni added the CLA not signed label Feb 12, 2017

Format URLs

a88fcf1

vstinner requested changes Feb 13, 2017

View reviewed changes

Further formatted text

08cb2a3

berkerpeksag added backport to 3.5 and removed CLA not signed labels Feb 13, 2017

the-knights-who-say-ni added the CLA not signed label Feb 13, 2017

ghost closed this Feb 15, 2017

Mariatta removed needs backport to 3.5 labels Feb 25, 2017

paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019

Merge pull request python#19 from paulmon/fix-venvlauncher

bbac193

Fix venvlauncher

pablogsal mentioned this pull request Jun 12, 2020

bpo-40958: Avoid buffer overflow in the parser when indexing the current line #20842

Closed

itachaaa mentioned this pull request Aug 22, 2022

Python 3.10 hang at exit in drop_gil() (due to resource warning at exit?) #91414

Open

mdboom mentioned this pull request Aug 25, 2022

Assert and incorrect error message when loading source file containing invalid UTF-8 #96268

Closed

mdboom mentioned this pull request Nov 22, 2022

Type punning (and strict aliasing) issue in Py_CLEAR() and Py_SETREF() macros: Python --enable-pystats is miscompiled #99701

Closed

ziegenbalg mentioned this pull request Nov 30, 2022

double free in io.TextIOWrapper #72573

Closed

jaraco pushed a commit that referenced this pull request Dec 2, 2022

If PR author is the same as the committer, only mention them once. (G…

b72583c

…H-19) Closes python/miss-islington#18

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

stasos24 mentioned this pull request Oct 24, 2023

Modules/cjkcodecs/_codecs_iso2022.c - read out of bounds #101180

Closed

williamhu020 mentioned this pull request Nov 5, 2023

Use the API C of 'Py-NewInterpreterFromConfig' to exit unexpectedly in multiple threads. #111751

Closed

kcatss mentioned this pull request Nov 15, 2023

Use-after-free in unregister() of atexit module #112127

Open

kcatss mentioned this pull request Jan 14, 2024

crash in long_vectorcall in longobject.c #114050

Closed

kcatss mentioned this pull request Feb 12, 2024

Segmentation Fault in pthread_getcpuclockid function in time module #115378

Closed

kcatss mentioned this pull request Feb 20, 2024

Use After Free at _heapreplace_max #115706

Closed

ngoldbaum mentioned this pull request Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename Doc/README.txt to Doc/README.rst #19

Rename Doc/README.txt to Doc/README.rst #19

ghost commented Feb 11, 2017

the-knights-who-say-ni commented Feb 11, 2017

methane Feb 11, 2017

zware Feb 11, 2017

methane Feb 11, 2017

methane Feb 11, 2017

methane commented Feb 11, 2017

orsenthil commented Feb 11, 2017

ghost commented Feb 11, 2017

methane commented Feb 11, 2017

vstinner left a comment

ghost commented Feb 12, 2017 •

edited by ghost

Loading

vstinner commented Feb 12, 2017

ghost commented Feb 12, 2017

ghost commented Feb 12, 2017

vstinner commented Feb 13, 2017

vstinner left a comment

vstinner Feb 13, 2017

vstinner Feb 13, 2017

vstinner Feb 13, 2017

vstinner Feb 13, 2017

ghost commented Feb 13, 2017 •

edited by ghost

Loading

codecov bot commented Feb 13, 2017

ghost commented Feb 13, 2017

ghost commented Feb 13, 2017

berkerpeksag commented Feb 13, 2017

ghost commented Feb 15, 2017

ghost commented Feb 15, 2017

		@@ -109,10 +109,10 @@ Contributing
		============

		Bugs in the content should be reported to the Python bug tracker at

Rename Doc/README.txt to Doc/README.rst #19

Rename Doc/README.txt to Doc/README.rst #19

Conversation

ghost commented Feb 11, 2017

the-knights-who-say-ni commented Feb 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

methane commented Feb 11, 2017

orsenthil commented Feb 11, 2017

ghost commented Feb 11, 2017

methane commented Feb 11, 2017

vstinner left a comment

Choose a reason for hiding this comment

ghost commented Feb 12, 2017 • edited by ghost Loading

vstinner commented Feb 12, 2017

ghost commented Feb 12, 2017

ghost commented Feb 12, 2017

vstinner commented Feb 13, 2017

vstinner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Feb 13, 2017 • edited by ghost Loading

codecov bot commented Feb 13, 2017

Codecov Report

ghost commented Feb 13, 2017

ghost commented Feb 13, 2017

berkerpeksag commented Feb 13, 2017

ghost commented Feb 15, 2017

ghost commented Feb 15, 2017

ghost commented Feb 12, 2017 •

edited by ghost

Loading

ghost commented Feb 13, 2017 •

edited by ghost

Loading