-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40958: Avoid buffer overflow in the parser when indexing the current line #20842
Conversation
Before this PR
After this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is failing:
======================================================================
FAIL: testSyntaxErrorOffset (test.test_exceptions.ExceptionTests) (source=b'Python = "\xcf\xb3\xf2\xee\xed" +', lineno=1, offset=18)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\lib\test\test_exceptions.py", line 188, in check
self.assertEqual(cm.exception.offset, offset)
AssertionError: 13 != 18
When you're done making the requested changes, leave the comment: |
Closing this as this is missing something important and unfortunately, I don't have time to investigate today :( |
@lysnikolaou Feel free to investigate if you have some time |
I'll do as soon as I get home. Sorry for not being able to help out now! |
https://bugs.python.org/issue40958