Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the original author and the committer is the same... #18

Closed
serhiy-storchaka opened this issue Sep 8, 2017 · 2 comments
Closed

If the original author and the committer is the same... #18

serhiy-storchaka opened this issue Sep 8, 2017 · 2 comments
Labels
enhancement

Comments

@serhiy-storchaka
Copy link
Member

I just have merged my first PR after miss-islington become working. If the original author and the committer is the same person, miss-islington's comment's look slightly strange.

Thanks @serhiy-storchaka for the PR, and @serhiy-storchaka for merging it

Sorry, @serhiy-storchaka and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.

This is low priority, but I think that it would be nice to not duplicate the name in this case.

Thank you for your awesome work @Mariatta! Your tools help a lot!
Mariatta added a commit to Mariatta/miss-islington that referenced this issue Sep 9, 2017
@Mariatta
If PR author is the same as the committer, only mention them once.
37c4d47 
Closes python#18
@Mariatta Mariatta mentioned this issue Sep 9, 2017
Merged
Mariatta added a commit to Mariatta/miss-islington that referenced this issue Sep 9, 2017
@Mariatta
If PR author is the same as the committer, only mention them once.
2827462 
Closes python#18
Mariatta added a commit that referenced this issue Sep 9, 2017
@Mariatta
If PR author is the same as the committer, only mention them once. (G…
b72583c 
…H-19)

Closes #18
@Mariatta
Copy link
Member

Mariatta commented Sep 9, 2017

Thanks @serhiy-storchaka 😄
I updated the bot, now if the committer and PR author is the same, only one of them gets mentioned.

@Mariatta Mariatta reopened this Sep 9, 2017
@Mariatta Mariatta closed this as completed Sep 9, 2017
@serhiy-storchaka
Copy link
Member Author

Thank you @Mariatta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serhiy-storchaka @Mariatta