Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105751: test_ctypes avoids the operator module #105797

Merged
merged 1 commit into from
Jun 14, 2023
Merged

gh-105751: test_ctypes avoids the operator module #105797

merged 1 commit into from
Jun 14, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 14, 2023 •
edited by bedevere-bot
Loading

  • Replace operator.delitem(obj, index) with "del obj[index]".
  • Replace operator.setitem(obj, index, value) with "obj[index] = value".
  • Replace delattr(obj, "attr) with "del obj.attr".
  • Replace grc() with sys.getrefcount() for readability.

@vstinner
pythongh-105751: test_ctypes avoids the operator module
1ecbc7f 
* Replace operator.delitem(obj, index) with "del obj[index]".
* Replace operator.setitem(obj, index, value) with
  "obj[index] = value".
* Replace delattr(obj, "attr) with "del obj.attr".
* Replace grc() with sys.getrefcount() for readability.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 14, 2023
Closed
@zware zware enabled auto-merge (squash) June 14, 2023 20:59
@zware zware merged commit 5ab13c5 into python:main Jun 14, 2023
@vstinner vstinner deleted the test_ctypes_replace branch June 14, 2023 22:28
@vstinner
Copy link
Member Author

Thanls for the review @zware.

carljm added a commit to carljm/cpython that referenced this pull request Jun 15, 2023
@carljm
Merge branch 'main' into modulelocals
166aca9 
* main: (57 commits)
  pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833)
  pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)
  pythongh-105751, test_ctypes: Remove disabled tests (python#105826)
  pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)
  pythongh-105751: Remove platform usage in test_ctypes (python#105819)
  pythongh-105751: Reenable disable test_ctypes tests (python#105818)
  pythongh-105751: Remove dead code in test_ctypes (python#105817)
  More reorganisation of the typing docs (python#105787)
  Improve docs for `typing.dataclass_transform` (python#105792)
  pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)
  pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)
  pythongh-105751: Cleanup test_ctypes imports (python#105803)
  pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)
  pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)
  pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)
  pythongh-104909: Implement conditional stack effects for macros (python#105748)
  pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)
  pythongh-105481: Fix types and a bug for pseudos (python#105788)
  Update DSL docs for cases generator (python#105753)
  pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @zware @bedevere-bot