Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test___all__.AllTest.test_all is failing on every PR #105821

Closed
AlexWaygood opened this issue Jun 15, 2023 · 6 comments
Closed

test___all__.AllTest.test_all is failing on every PR #105821

AlexWaygood opened this issue Jun 15, 2023 · 6 comments
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 15, 2023

Bug report

Following #105801, test___all__.AllTest.test_all is failing on every non-docs PR on the "Hypothesis tests on Ubuntu" CI job.

The traceback is:

======================================================================
FAIL: test_all (test.test___all__.AllTest.test_all)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test___all__.py", line 129, in test_all
    self.check_all(modname)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test___all__.py", line 43, in check_all
    with warnings_helper.check_warnings(
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/support/warnings_helper.py", line 185, in _filterwarnings
    raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : SyntaxWarning("invalid escape sequence '\\?'"), category : 'SyntaxWarning', filename : '/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_httpservers.py', lineno : 445, line : None}

Example failures:

This failure was visible in the CI for #105801 FYI

Linked PRs

@AlexWaygood AlexWaygood added the type-bug An unexpected behavior, bug, or error label Jun 15, 2023
@pablogsal
Copy link
Member

This failure was visible in the CI for #105801 FYI

But then how is possible that we could land that PR?

@pablogsal
Copy link
Member

pablogsal commented Jun 15, 2023

Ah, because hypothesis tests are not mandatory. Well, this is what I feared that would happen having non-mandatory tests that are already failing for other reasons 😞

@AlexWaygood
Copy link
Member Author

Ah, because hypothesis tests are not mandatory.

Indeed

Well, this is what I feared that would happen having non-mandatory tests that are already failing for other reasons 😞

FWIW, I haven't seen any failures on the "hypothesis tests" job since @ericsnowcurrently fixed the test__xxsubinterpreter and test_threading crashes. We could probably make it a "required" CI check at this point.

@pablogsal
Copy link
Member

We could probably make it a "required" CI check at this point.

I think we should

@AlexWaygood
Copy link
Member Author

We could probably make it a "required" CI check at this point.

I think we should

We should probably continue discussion on the matter at #86275

pablogsal added a commit that referenced this issue Jun 15, 2023
Use a raw f-string in test_httpservers.py
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 15, 2023
…105822)

Use a raw f-string in test_httpservers.py
(cherry picked from commit 09ce8c3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
AlexWaygood pushed a commit that referenced this issue Jun 15, 2023
… (#105824)

gh-105821: Use a raw f-string in test_httpservers.py (GH-105822)

Use a raw f-string in test_httpservers.py
(cherry picked from commit 09ce8c3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@AlexWaygood
Copy link
Member Author

Thanks for the quick fix @pablogsal!!

carljm added a commit to carljm/cpython that referenced this issue Jun 15, 2023
* main: (57 commits)
  pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833)
  pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)
  pythongh-105751, test_ctypes: Remove disabled tests (python#105826)
  pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)
  pythongh-105751: Remove platform usage in test_ctypes (python#105819)
  pythongh-105751: Reenable disable test_ctypes tests (python#105818)
  pythongh-105751: Remove dead code in test_ctypes (python#105817)
  More reorganisation of the typing docs (python#105787)
  Improve docs for `typing.dataclass_transform` (python#105792)
  pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)
  pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)
  pythongh-105751: Cleanup test_ctypes imports (python#105803)
  pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)
  pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)
  pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)
  pythongh-104909: Implement conditional stack effects for macros (python#105748)
  pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)
  pythongh-105481: Fix types and a bug for pseudos (python#105788)
  Update DSL docs for cases generator (python#105753)
  pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132)
  ...
lazka pushed a commit to msys2-contrib/cpython-mingw that referenced this issue Jul 19, 2023
lazka pushed a commit to msys2-contrib/cpython-mingw that referenced this issue Jul 19, 2023
lazka pushed a commit to msys2-contrib/cpython-mingw that referenced this issue Aug 25, 2023
lazka pushed a commit to msys2-contrib/cpython-mingw that referenced this issue Aug 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 28, 2023
…105822)

Use a raw f-string in test_httpservers.py
(cherry picked from commit 09ce8c3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
AlexWaygood pushed a commit that referenced this issue Aug 28, 2023
… (#108576)

gh-105821: Use a raw f-string in test_httpservers.py (GH-105822)

Use a raw f-string in test_httpservers.py
(cherry picked from commit 09ce8c3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 15, 2024
…105822)

Use a raw f-string in test_httpservers.py
(cherry picked from commit 09ce8c3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants