gh-102498 Clean up unused variables and imports in the email module

[JosephSBoyle]

Found some unused vars using the following pyflakes command $ python3.12 -m pyflakes Lib/email/. Inspired by @AlexWaygood 's use of the tool to find issues in the test_typing.py file (can't seem to find the exact issue).

Cleanup some unused variables and imports in the email module.

In text.py I replaced a pagebreak character (U+000C) with a newline. The latter doesn't seem to be rendered by GH. VScode shows it, as will most editors I imagine.

GH Issue: #102498

• Issue: Clean up unused variables and imports in the email module #102498

[warsaw]

Thanks for the cleanup. I can review it in more detail after a few housekeeping updates have been made (updating the branch to current HEAD, creating an issue, and adding an issue number).

You can just delete the page feed line (see PEP 8, two blank lines only between top level constructs). The page feeds are a historical holdover for when this library was developed independently.

[hugovk]

To appease Bedevere about the issue number, please prefix the PR title as "gh-XXXXX:"

[JosephSBoyle]

Hi @warsaw, thanks for the quick response. I've added an issue, rebased to the current HEAD and removed that extra line as you requested. Should be good for a review now.

@hugovk cheers for the headsup r.e the issue number.

[terryjreedy]

If you used a program/linter to find these, please add 'found by xxxx' to the first sentence in the message.

[hugovk]

Also an unused msg here (found by Flake8):

cpython/Lib/email/feedparser.py

Line 269 in 4a3ea1f

msg = self._pop_message()

[JosephSBoyle]

There are 45 pagebreaks remaining in the entire cpython repo, 34 of which are in email. I'm happy to replace them with newlines / delete them as appropriate per pep-8 if people want them gone. Might be something for another issue though:)

[AlexWaygood]

There are 45 pagebreaks remaining in the entire cpython repo, 34 of which are in email. I'm happy to replace them with newlines / delete them as appropriate per pep-8 if people want them gone. Might be something for another issue though:)

I agree with @warsaw that it's now time for these to go, but it would be better to remove all of them from the stdlib at once, in a separate PR, I think, rather than in this PR.

(Not requesting a change to this PR; it's fine to remove the one you're already removing, in my opinion, since you're already touching that file :)

[AlexWaygood]

Inspired by @AlexWaygood 's use of the tool to find issues in the test_typing.py file (can't seem to find the exact issue).

This is the one:

• Several minor bugs in test_typing highlighted by pyflakes #102444

[JosephSBoyle]

I appear to have duplicated the commits during the merge somehow. I would rebase and drop them but I'm under the impression that force-pushing is discouraged. If we merge this PR they'll all be squashed anyways as I understand it.. Let me know if dropping the duplicated commits is preferable and I can do that:)

[hugovk]

Correct, all PRs are squashed and merged, so don't worry about the individual commits too much. 👍

[JosephSBoyle]

Hi @warsaw. Could you please take a look at this when you get a chance?