Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invisible pagebreak chars from the standard library #102507

Closed
JosephSBoyle opened this issue Mar 7, 2023 · 1 comment · Fixed by #102531
Closed

Remove invisible pagebreak chars from the standard library #102507

JosephSBoyle opened this issue Mar 7, 2023 · 1 comment · Fixed by #102531
Labels
type-feature A feature request or enhancement

Comments

@JosephSBoyle
Copy link
Contributor

JosephSBoyle commented Mar 7, 2023 •
edited by bedevere-bot
Loading

Following a discussion on a PR to clean up some unused vars in the email module: #102482,
there seemed to be a general feeling that we should remove invisible pagebreak characters (U+000C) from the standard library.

A quick ctrf-f with vscode shows <50 occurences which I proposed be deleted and optionally replaced with newlines. Each change should be checked for pep-8 compliance, in particular the 2-newlines rule.

I'm happy to submit a PR for this.

Linked PRs
@JosephSBoyle JosephSBoyle added the type-feature A feature request or enhancement label Mar 7, 2023
@JosephSBoyle
Copy link
Contributor Author

separate PR for removing pagebreaks following our conversation here: #102482

@AlexWaygood @warsaw

@bedevere-bot bedevere-bot mentioned this issue Mar 8, 2023
Merged
@AlexWaygood AlexWaygood linked a pull request Mar 8, 2023 that will close this issue
gh-102507 Remove invisible pagebreak characters #102531
Merged
AlexWaygood added a commit that referenced this issue Mar 8, 2023
@JosephSBoyle @AlexWaygood
gh-102507 Remove invisible pagebreak characters (#102531)
b097925 
Co-authored-by: AlexWaygood <[email protected]>
carljm added a commit to carljm/cpython that referenced this issue Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 22, 2023
@JosephSBoyle @AlexWaygood @miss-islington
pythongh-102507 Remove invisible pagebreak characters (pythonGH-102531)
61d3a8a 
(cherry picked from commit b097925)

Co-authored-by: JosephSBoyle <[email protected]>
Co-authored-by: AlexWaygood <[email protected]>
AlexWaygood added a commit that referenced this issue Aug 22, 2023
@miss-islington @JosephSBoyle @AlexWaygood
[3.11] gh-102507 Remove invisible pagebreak characters (GH-102531) (#…
dd0a1f9 
…108266)

gh-102507 Remove invisible pagebreak characters (GH-102531)
(cherry picked from commit b097925)

Co-authored-by: JosephSBoyle <[email protected]>
Co-authored-by: AlexWaygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-102507 Remove invisible pagebreak characters JosephSBoyle/cpython
1 participant
@JosephSBoyle