Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in async generator code field name ag_code #102448

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix typo in async generator code field name ag_code #102448

merged 1 commit into from
Mar 8, 2023

Conversation

kumaraditya303
Copy link
Contributor

No description provided.

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 5, 2023 •
edited
Loading

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

(The change looks correct, but it's weird to me that this wasn't flagged by our tests -- worth a test, maybe? But as I say, I'm probably not the right reviewer here :)

@AlexWaygood AlexWaygood removed their request for review March 5, 2023 17:55
@kumaraditya303
Copy link
Contributor Author

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

I didn't mean to request review, might have mis-clicked while applying labels or got distracted and didn't see. Sorry.

@kumaraditya303 kumaraditya303 merged commit e499680 into python:main Mar 8, 2023
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the typo branch March 8, 2023 03:39
@miss-islington
Copy link
Contributor

Sorry, @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.11

@miss-islington
Copy link
Contributor

Sorry @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.10

carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @AlexWaygood @miss-islington @bedevere-bot