-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94518: Port 23-argument _posixsubprocess.fork_exec
to Argument Clinic
#94519
gh-94518: Port 23-argument _posixsubprocess.fork_exec
to Argument Clinic
#94519
Conversation
You are passing You can solve the problem and get rid of
|
Now it builds but crashes the interpreter while Ubuntu CI run:
|
From Ubuntu runner build logs:
@tiran Any ideas how it can be possible? A compiler points to a fused declaration and assignment complaining that an assignment may be missing. |
@tiran Thank you, addressed in gh-94687. Would you mind to take a look please (and add |
Please include a news entry. We typically only skip news if the change is a trivial internal change or change is already covered by a previous PR. Non-trivial commits get a news entry so other core devs, release manager, distributors, and users have an easier way to locate a problem when a change introduces a regression. |
Done (initially I've thought this change is invisible to users so skipped it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this is in good shape. one change to make.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit 7251169 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit 7251169 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Restarted the tests to check that it isn't a fluke (other runners finished successfully). |
🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit c7e1a5e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit cda283a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
buildbot test failures appear unrelated at a glance. i'm going to try and get this merged today. |
thanks for sticking with this and improving this code! |
@gpshead Thank you for merging (and ten-month-long patience despite a constant stream of notifications)! |
* main: (53 commits) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) Add tests for empty range equality (python#103751) pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713) ...
* superopt: (82 commits) pythongh-101517: fix line number propagation in code generated for except* (python#103550) pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) ...
Edit: in addition to what a title says, this PR also removes theoretical situation of
/call_set[ug]id==true/
with uninitialized/[ug]id/
. This is required to avoid undefined behavior (as Christian Heimes initially pointed out). A full removal ofcall_setgid
will be done in a separate PR.To break nothing, the porting was done in steps, a commit per each:
Also, it fixes minor bug traps:
assignsmoved out into gh-94518: [_posixsubprocess] Replace variable validity flags with reserved values #94687(...id)-1
as an impossible default value togid
anduid
local variables (thanks to Christian for proposing this)_posixsubprocess.fork_exec
to Argument Clinic #94518