Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the sqlite3 reference #95273

Closed
5 tasks done
erlend-aasland opened this issue Jul 26, 2022 · 2 comments · Fixed by #95523, #95379, #95274, #95430 or #95351
Closed
5 tasks done

Improve the sqlite3 reference #95273

erlend-aasland opened this issue Jul 26, 2022 · 2 comments · Fixed by #95523, #95379, #95274, #95430 or #95351
Assignees
Labels
docs Documentation in the Doc dir triaged The issue has been accepted as valid by a triager.

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jul 26, 2022

Improve the sqlite3 reference, using Diataxis as a guideline. A lot of work has already been done here, with great help from Alex Waygood and CAM Gerlach. PRs so far1 have focused on...:

Previous work over the last few years

Both of these have been improved greatly by the following issues and PRs, amongst others:

There are remaining issues, though:

Footnotes

  1. There have been too many PRs to list; some of them were done before Diataxis was even discussed.

@erlend-aasland erlend-aasland self-assigned this Jul 26, 2022
@erlend-aasland erlend-aasland added docs Documentation in the Doc dir triaged The issue has been accepted as valid by a triager. labels Jul 26, 2022
@erlend-aasland erlend-aasland changed the title Normalise wording of sqlite3 function and method docs Normalise sqlite3 reference doc wording Jul 26, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 26, 2022
@erlend-aasland erlend-aasland moved this from TODO: Docs to In Progress in sqlite3 issues Jul 26, 2022
@erlend-aasland erlend-aasland changed the title Normalise sqlite3 reference doc wording Improve the sqlite3 reference Jul 27, 2022
erlend-aasland pushed a commit that referenced this issue Jul 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this issue Jul 27, 2022
…95274)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this issue Jul 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jul 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 27, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 28, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2022
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2022
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2022
…utorial (pythonGH-95351)

(cherry picked from commit f0bf795)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2022
…utorial (pythonGH-95351)

(cherry picked from commit f0bf795)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Repository owner moved this from In Progress to Done in sqlite3 issues Aug 4, 2022
erlend-aasland added a commit that referenced this issue Aug 4, 2022
…sqlite3 class methods (#95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 4, 2022
…s raised for sqlite3 class methods (pythonGH-95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 4, 2022
…s raised for sqlite3 class methods (pythonGH-95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland reopened this Aug 4, 2022
erlend-aasland added a commit that referenced this issue Aug 4, 2022
…ed for sqlite3 class methods (GH-95530) (#95673)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 4, 2022
…ed for sqlite3 class methods (GH-95530) (#95674)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 8, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 8, 2022
…vars (pythonGH-95626)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 41c939c)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 8, 2022
…vars (pythonGH-95626)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 41c939c)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 8, 2022
…H-95626) (#95803)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 41c939c)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 9, 2022
…H-95626) (#95801)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 41c939c)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 9, 2022
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
…d for sqlite3 class methods (python#95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
erlend-aasland added a commit that referenced this issue Aug 11, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 12, 2022
…nGH-95840)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit e6623e7)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 12, 2022
…nGH-95840)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit e6623e7)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 12, 2022
…95917)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit e6623e7)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Aug 12, 2022
…95918)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit e6623e7)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
Copy link
Contributor Author

I'm going to close this issue:

  • it is close to impossible to say when such a meta-issue can be closed as it's goal is a moving target
  • most of the issues pointed out have been fixed

Further work can be done either without PRs (moving a section, minor rewordings, etc.) or with better targeted issues.

@erlend-aasland
Copy link
Contributor Author

A big thanks to Alex, CAM, and Ezio, who have been helping out by improving the quality of the changes considerably. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment