Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document all parameters of all sqlite3 functions/methods #95235

Closed
erlend-aasland opened this issue Jul 25, 2022 · 1 comment
Closed

Document all parameters of all sqlite3 functions/methods #95235

erlend-aasland opened this issue Jul 25, 2022 · 1 comment
Assignees
@erlend-aasland
Labels
docs Documentation in the Doc dir triaged The issue has been accepted as valid by a triager.

Comments

@erlend-aasland
Copy link
Contributor

Ref. #94320 (comment)

Also consider using explicit parameter lists more often (or always?). Obvious candidates for explicit parameter lists:

  • sqlite3.Connection.create_*
  • sqlite3.Connection.blobopen
  • sqlite3.Connection.backup
@erlend-aasland erlend-aasland added the docs Documentation in the Doc dir label Jul 25, 2022
@erlend-aasland erlend-aasland self-assigned this Jul 25, 2022
@erlend-aasland erlend-aasland moved this from TODO: Docs to In Progress in sqlite3 issues Jul 25, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 25, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 25, 2022
@erlend-aasland
pythongh-95235: Document undocumented parameters in sqlite3 functions…
bbe34c5 
… and methods
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 25, 2022
@erlend-aasland
pythongh-95235: Add explicit parameter list to some sqlite3 methods
1d030fa
@bedevere-bot bedevere-bot mentioned this issue Jul 25, 2022
Merged
@erlend-aasland erlend-aasland added the triaged The issue has been accepted as valid by a triager. label Jul 25, 2022
This was referenced Jul 25, 2022
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 25, 2022
@erlend-aasland @miss-islington
pythongh-95235: Document undocumented parameters in sqlite3 functions…
04ce3fb 
… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 25, 2022
@erlend-aasland @miss-islington
pythongh-95235: Document undocumented parameters in sqlite3 functions…
1b7f459 
… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Jul 25, 2022
@erlend-aasland @CAM-Gerlach
gh-95235: Document undocumented parameters in sqlite3 functions and m…
ac6a94c 
…ethods (#95236)

Co-authored-by: CAM Gerlach <[email protected]>
miss-islington added a commit that referenced this issue Jul 25, 2022
@miss-islington @erlend-aasland
gh-95235: Document undocumented parameters in sqlite3 functions and m…
4c10dba 
…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this issue Jul 25, 2022
@miss-islington @erlend-aasland
gh-95235: Document undocumented parameters in sqlite3 functions and m…
0418d9f 
…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Jul 26, 2022
@erlend-aasland @CAM-Gerlach
gh-95235: Add explicit parameter list to some sqlite3 methods (#95240)
5012bed 
Co-authored-by: CAM Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 26, 2022
@erlend-aasland @miss-islington
pythongh-95235: Add explicit parameter list to some sqlite3 methods (p…
517090f 
…ythonGH-95240)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 5012bed)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 26, 2022
@erlend-aasland
[3.10] pythongh-95235: Add explicit parameter list to some sqlite3 me…
dcd549c 
…thods (pythonGH-95240)

Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 5012bed)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
@erlend-aasland
Copy link
Contributor Author

Fixed by:

@erlend-aasland erlend-aasland moved this from In Progress to Done in sqlite3 issues Jul 26, 2022
erlend-aasland added a commit that referenced this issue Jul 26, 2022
@erlend-aasland
[3.10] gh-95235: Add explicit parameter list to some sqlite3 methods (G…
a4fd732 
…H-95240) (#95268)

Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 5012bed)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
ambv pushed a commit that referenced this issue Jul 26, 2022
@miss-islington @erlend-aasland
gh-95235: Add explicit parameter list to some sqlite3 methods (GH-95240…
5a9920f 
…) (GH-95263)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 5012bed)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this issue Jul 27, 2022
Closed
5 tasks
@shawnbrown shawnbrown mentioned this issue Sep 12, 2022
Closed
shawnbrown added a commit to shawnbrown/toron that referenced this issue Sep 12, 2022
@shawnbrown
Update get_raw_quantities() to use userfunc context manager.
014568a 
And remove accepts_json_input() and related tests.

The `userfunc` context manager creates AND REMOVES user-
defined functions. It is no longer necessary to have the
`accepts_json_input` weapper class.

Documentation for the sqlite3 Connection.create_function()
method now say that the *func* parameter may be "Set to None
to remove an existing SQL function." BUT PRIOR TO PYTHON 3.10.5,
SQL FUNCTION REMOVAL WAS UNDOCUMENTED! The new language was
added July 26, 2022 (python/cpython@5012bed) and is related
to Issue 95235 (python/cpython#95235).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir triaged The issue has been accepted as valid by a triager.
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland