Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions #95523

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 1, 2022

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy one to review!

@erlend-aasland
Copy link
Contributor Author

That was an easy one to review!

I remembered you said you were swamped with work at the moment, so I took the chance with a small PR :)

@erlend-aasland erlend-aasland merged commit 1e6b635 into python:main Aug 1, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-reference/improve-exception-accuracy branch August 1, 2022 09:15
@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1e6b63542e4856436c5c12148a6608ef9d148b71 3.10

@bedevere-bot
Copy link

GH-95524 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
… exceptions (pythonGH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
5 tasks
@erlend-aasland erlend-aasland removed the needs backport to 3.10 only security fixes label Aug 1, 2022
@erlend-aasland
Copy link
Contributor Author

Removing 3.10 backport, as 3.10 does not have this feature.

miss-islington added a commit that referenced this pull request Aug 1, 2022
…tions (GH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference
4 participants