Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clinic test are skipped on Windows #104629

Closed
erlend-aasland opened this issue May 18, 2023 · 3 comments
Closed

Clinic test are skipped on Windows #104629

erlend-aasland opened this issue May 18, 2023 · 3 comments
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 18, 2023 •
edited by bedevere-bot
Loading

test_clinic is skipped on Windows. This is a regression introduced by gh-96178.

  • The Modules/_testclinic.c helper extension module is not included in the Windows build
  • test.support.import_helper.import_module("_testclinic") fails and skips the whole test, since _testclinic is not found

Linked PRs
@erlend-aasland erlend-aasland added type-bug An unexpected behavior, bug, or error OS-windows build The build process and cross-build labels May 18, 2023
@bedevere-bot bedevere-bot mentioned this issue May 18, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 18, 2023
@erlend-aasland
pythongh-104629: Don't skip test_clinic if _testclinic is missing
f483652 
Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 18, 2023 •
edited
Loading

I'll leave the Windows specific part to someone with a Windows dev environment set up; I'm not comfortable doing the needed build changes in PCbuild/.

cc. @python/windows-team

erlend-aasland added a commit that referenced this issue May 18, 2023
@erlend-aasland
gh-104629: Don't skip test_clinic if _testclinic is missing (#104630)
86ee49f 
Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
@bedevere-bot bedevere-bot mentioned this issue May 18, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 18, 2023
@erlend-aasland @miss-islington
pythongh-104629: Don't skip test_clinic if _testclinic is missing (py…
e966306 
…thonGH-104630)

Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
(cherry picked from commit 86ee49f)

Co-authored-by: Erlend E. Aasland <[email protected]>
AlexWaygood pushed a commit that referenced this issue May 18, 2023
@miss-islington @erlend-aasland
[3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (G…
3d52f7e 
…H-104630) (#104632)

gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630)

Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
(cherry picked from commit 86ee49f)

Co-authored-by: Erlend E. Aasland <[email protected]>
carljm added a commit to carljm/cpython that referenced this issue May 18, 2023
@carljm
Merge branch 'main' into nestedcomps
54095f0 
* main:
  pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)
  pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)
  pythongh-104050: Add more type annotations to Argument Clinic (python#104628)
  pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)
  pythongh-104549: Set __module__ on TypeAliasType (python#104550)
  pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)
  pythongh-104146: Remove unused vars from Argument Clinic (python#104627)
  pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)
  pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)
  pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)
  pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
@bedevere-bot bedevere-bot mentioned this issue May 21, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 21, 2023
@erlend-aasland
pythongh-104629: Build _testclinic extension module on Windows
b0f5a4e
@bedevere-bot bedevere-bot mentioned this issue Jul 28, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 28, 2023
@erlend-aasland @miss-islington
pythongh-104629: Build _testclinic extension module on Windows (pytho…
55a45d6 
…nGH-104723)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Jul 28, 2023
@erlend-aasland
gh-104629: Build _testclinic extension module on Windows (#104723)
3a1d819
erlend-aasland added a commit that referenced this issue Jul 28, 2023
@miss-islington @erlend-aasland
[3.12] gh-104629: Build _testclinic extension module on Windows (GH-1…
b4355de 
…04723) (#107393)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
@hugovk
Copy link
Member

hugovk commented Nov 10, 2023

I'll leave the Windows specific part to someone with a Windows dev environment set up; I'm not comfortable doing the needed build changes in PCbuild/.

Is everything done now? Can we close this issue? Thanks!

@AlexWaygood
Copy link
Member

As far as I can tell, all clinic tests are now executed when I run python -m test test_clinic -v locally on my Windows box 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @erlend-aasland @AlexWaygood