Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104629: Build _testclinic extension module on Windows #104723

Merged
merged 6 commits into from
Jul 28, 2023
Merged

gh-104629: Build _testclinic extension module on Windows #104723

merged 6 commits into from
Jul 28, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 21, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from a team as a code owner May 21, 2023 16:42
@bedevere-bot bedevere-bot mentioned this pull request May 21, 2023
Closed
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 21, 2023
@erlend-aasland
Copy link
Contributor Author

DISCLAIMER: I don't have a Windows dev environment set up; I don't know anything about Visual Code (Visual Studio?). I have no idea if this works.

FYI, I used random GUID's.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 21, 2023 •
edited
Loading

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)

@erlend-aasland
Copy link
Contributor Author

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)

Good to know! Thanks 😃

zooba
zooba reviewed May 22, 2023
View reviewed changes
PCbuild/pcbuild.sln Outdated
@@ -78,6 +79,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "_ssl", "_ssl.vcxproj", "{C6
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "_testcapi", "_testcapi.vcxproj", "{6901D91C-6E48-4BB7-9FEC-700C8131DF1D}"
EndProject
Project("{A840DDFB-ED50-484B-B527-B32E7CF90FD5}") = "_testclinic", "_testclinic.vcxproj", "{A840DDFB-ED50-484B-B527-B32E7CF90FD5}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first guid should match the rest - it's the kind of the project, not the specific identifier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

Let me try again: how does 355f339 and e9aa5a3 look?

PCbuild/pcbuild.proj Show resolved Hide resolved
@zware zware added the needs backport to 3.12 bug and security fixes label May 30, 2023
@erlend-aasland
Copy link
Contributor Author

@zooba or @zware: I totally forgot about this PR. With the current relatively high volume of clinic changes going on, I think it is important that we land this. Could one of you check if my last changes are ok?

zware
zware approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, and worked when I tried it. If there's anything we've missed, it can be cleaned up later :)

@erlend-aasland erlend-aasland merged commit 3a1d819 into python:main Jul 28, 2023
20 checks passed
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3a1d819ebc36189e086198212822c9b29384f242 3.11

@bedevere-bot
Copy link

GH-107393 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 28, 2023
@erlend-aasland erlend-aasland deleted the clinic/windows-build branch July 28, 2023 16:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
@erlend-aasland @miss-islington
pythongh-104629: Build _testclinic extension module on Windows (pytho…
55a45d6 
…nGH-104723)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 28, 2023
@miss-islington @erlend-aasland
[3.12] gh-104629: Build _testclinic extension module on Windows (GH-1…
b4355de 
…04723) (#107393)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
@zware zware removed the needs backport to 3.11 only security fixes label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

@erlend-aasland erlend-aasland

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @AlexWaygood @miss-islington @bedevere-bot @zooba @zware