gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function #104565
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
|
Thanks for looking at this! The default value of Could you also add tests please? I think they'll show that your current patch doesn't enable case-sensitive matching on Windows, because the implementation is still working with the case-normalized parts. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @barneygale: please review the changes made to this pull request. |
There was a problem hiding this comment.
Nice! Pretty close now. Could you add an entry to the 3.12 "What's New" document? Apparently I forgot to add a paragraph there for the addition of case_sensitive to glob() and rglob() - if you could mention all three in a single bullet point I'd be much obliged!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
the requested changes; please review again. |
Misc/NEWS.d/next/Library/2023-05-17-03-14-07.gh-issue-104484.y6KxL6.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Barney Gale <[email protected]>
…6KxL6.rst Co-authored-by: Barney Gale <[email protected]>
Co-authored-by: Barney Gale <[email protected]>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @barneygale: please review the changes made to this pull request. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @barneygale: please review the changes made to this pull request. |
* main: pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622) pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625) pythongh-104050: Add more type annotations to Argument Clinic (python#104628) pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630) pythongh-104549: Set __module__ on TypeAliasType (python#104550) pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626) pythongh-104146: Remove unused vars from Argument Clinic (python#104627) pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620) pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565) pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211) pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
pathlib.PurePath.match()#104484