fix(get-poetry): use exit code 1 with non-existing version #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`python get-poetry.py --version 0.12.34` should exit non-zero. This apparently regressed in 23667d2 [1]. 1: python-poetry@23667d2#diff-952871ed95a893e0348aa1269bf15e689d18756657cfec5c7316d05e55eb6dc6R302
kasteph
approved these changes
Apr 14, 2021
blueyed
added a commit
to blueyed/poetry
that referenced
this pull request
May 3, 2021
Follow-up to python-poetry#3927, which was reverted in python-poetry#3943, now handling the "Latest version already installed." case (python-poetry#3942).
blueyed
added a commit
to blueyed/poetry
that referenced
this pull request
May 3, 2021
Follow-up to python-poetry#3927, which was reverted in python-poetry#3943, now handling the "Latest version already installed." case (python-poetry#3942). Ref: python-poetry#4027
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python get-poetry.py --version 0.12.34should exit non-zero.This apparently regressed in 23667d2 [1].
1: 23667d2#diff-952871ed95a893e0348aa1269bf15e689d18756657cfec5c7316d05e55eb6dc6R302
Ref: #378