Skip to content

Commit

Permalink
fix(get-poetry): use exit code 1 with non-existing version
Browse files Browse the repository at this point in the history
`python get-poetry.py --version 0.12.34` should exit non-zero.

This apparently regressed in 23667d2 [1].

1: 23667d2#diff-952871ed95a893e0348aa1269bf15e689d18756657cfec5c7316d05e55eb6dc6R302
  • Loading branch information
blueyed authored and kasteph committed Apr 14, 2021
1 parent 2d99ab4 commit cd8ac0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion get-poetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def run(self):
version, current_version = self.get_version()

if version is None:
return 0
return 1

self.customize_install()
self.display_pre_message()
Expand Down

2 comments on commit cd8ac0d

@jacek-jablonski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, tens of CI scripts needs to be changed

@abn
Copy link
Member

@abn abn commented on cd8ac0d Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIll revert shortly.

Please sign in to comment.