Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer should exit non-zero in case of non-existent/invalid --version #4027

Closed
blueyed opened this issue May 3, 2021 · 2 comments
Closed

Installer should exit non-zero in case of non-existent/invalid --version #4027

blueyed opened this issue May 3, 2021 · 2 comments
Labels
kind/bug Something isn't working as expected

Comments

@blueyed
Copy link
Contributor

blueyed commented May 3, 2021

python get-poetry.py --version 0.12.34 should exit non-zero.

This apparently regressed in 23667d2 [1].

1: 23667d2#diff-952871ed95a893e0348aa1269bf15e689d18756657cfec5c7316d05e55eb6dc6R302

Ref: #378

Initially fixed in #3927, but incomplete and has been reverted therefore.
@blueyed blueyed added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels May 3, 2021
blueyed added a commit to blueyed/poetry that referenced this issue May 3, 2021
@blueyed
fix(get-poetry): use exit code 1 with non-existing version
1a13dd2 
Follow-up to python-poetry#3927, which
was reverted in python-poetry#3943,
now handling the "Latest version already installed." case
(python-poetry#3942).

Ref: python-poetry#4027
@blueyed blueyed mentioned this issue May 3, 2021
Closed
2 tasks
blueyed added a commit to blueyed/poetry that referenced this issue May 3, 2021
@blueyed
fix(install-poetry): use exit code 1 with non-existing version
48ba2f1 
Ref: python-poetry#4027
@blueyed blueyed mentioned this issue May 3, 2021
Closed
2 tasks
@neersighted
Copy link
Member

Closing this issue as get-poetry.py is deprecated.

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blueyed @abn @neersighted