Merge master into features #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when suspending - solves bug but still missing tests), reorganized functions and context managers.
more autodocs for pytester
Use more flexible `language_version: python3`
Fixtures during teardown can use capsys and capfd to get output from tests
Add a check before printing teardown logs. 'print_teardown_sections' method does not check '--show-capture' option value, and teardown logs are always printed. Resolves: pytest-dev#3816
…li-logging Bugfix/capsys with cli logging (again)
The documentation (https://docs.pytest.org/en/latest/skipping.html) references issue pytest-dev#568, which has since been fixed.
The problem was that _matchnodes would receive two items: [DoctestModule, Module]. It would then collect the first one, *cache it*, and fail to match against the name in the command line. Next, it would reuse the cached item (DoctestModule) instead of collecting the Module which would eventually find the "test" name on it. Added the type of the node to the cache key to avoid this problem, although I'm not a big fan of caches that have different key types. Fix pytest-dev#3843
Remove warning about pytest-dev#568 from documentation
Fix '--show-capture=no' capture teardown logs
Fix collection error when tests is specified with --doctest-modules
…ames. The test doesn't make sense for Windows, because of its case-insensitivity.
Correct cmdclass for doc: Good Integration Practices
Noticed these while working in something else
This will run it with `--show-diff-on-failure` then, and helps to keep it in line / in a central place.
The code in test_pytester has been refactored into a class right above the dead code, and the code has been left there by mistake apparently.
Travis: use TOXENV=linting for linting stage
This is meant to get base coverage on master for codecov.
I just noticed the newly committed code block doesn't format as a code block without `::` in the paragraph before. Perhaps doesn't make a difference, but also corrected 5 spaces to 4 which seems standard.
Collect tests from __init__.py files if they match 'python_files'
Remove dangerous sys.path manipulations in test_pluginmanager
Use skip_install for testing tox env
tox: coveralls: also report to codecov
Code block: :: missing and 4 spaces instead of 5
Codecov Report
@@ Coverage Diff @@
## features #3884 +/- ##
===========================================
Coverage ? 92.64%
===========================================
Files ? 51
Lines ? 9964
Branches ? 0
===========================================
Hits ? 9231
Misses ? 733
Partials ? 0
Continue to review full report at Codecov.
|
asottile
approved these changes
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.