Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '--show-capture=no' capture teardown logs #3841

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

sankt-petersbug
Copy link
Contributor

Add a check before printing teardown logs.

'print_teardown_sections' method does not check '--show-capture' option
value, and teardown logs are always printed.

Resolves: #3816

Add a check before printing teardown logs.

'print_teardown_sections' method does not check '--show-capture' option
value, and teardown logs are always printed.

Resolves: pytest-dev#3816
@coveralls
Copy link

coveralls commented Aug 20, 2018

Coverage Status

Coverage increased (+0.06%) to 92.647% when pulling 672f4bb on sankt-petersbug:fix-3816 into 43657f2 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @sankt-petersbug!

@RonnyPfannschmidt RonnyPfannschmidt merged commit 3b521be into pytest-dev:master Aug 22, 2018
@RonnyPfannschmidt
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants