Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: coveralls: also report to codecov #3877

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 25, 2018

This is meant to get base coverage on master for codecov.

Superseded then by #2800, but allows for seeing how #2800 improves things and that nothing regresses, e.g. because of usedevelop not being used there etc.

@coveralls
Copy link

coveralls commented Aug 26, 2018

Coverage Status

Coverage increased (+0.05%) to 92.639% when pulling d3f5324 on blueyed:codecov-master into 71b4995 on pytest-dev:master.

@blueyed blueyed self-assigned this Aug 26, 2018
@nicoddemus
Copy link
Member

Should we be seeing a report from codecov by now at this point?

This is meant to get base coverage on master for codecov.
@blueyed
Copy link
Contributor Author

blueyed commented Aug 26, 2018

@nicoddemus
It failed - likely missing some passenv, amended it.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 26, 2018

@nicoddemus
btw: maybe you could give me permissions to cancel/restart AppVeyor builds - it is having a hard time (unnecessarily): https://ci.appveyor.com/project/pytestbot/pytest/history

@nicoddemus
Copy link
Member

@blueyed I believe you can login in the pytestbot account? It lists you as a collaborator already.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 26, 2018

@nicoddemus
Logged into it explicitly via /login, and now only see pytest-dev related projects, but still cannot cancel builds.

There is no "switch account" feature, is there? - so this is a bit of a hassle anyway.

@nicoddemus
Copy link
Member

There is no "switch account" feature, is there? - so this is a bit of a hassle anyway.

I usually sign out from my account and login as pytestbot, and then I can cancel builds...

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@71b4995). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3877   +/-   ##
=========================================
  Coverage          ?   92.63%           
=========================================
  Files             ?       51           
  Lines             ?     9957           
  Branches          ?        0           
=========================================
  Hits              ?     9224           
  Misses            ?      733           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b4995...d3f5324. Read the comment docs.

@nicoddemus nicoddemus merged commit 4d19b94 into pytest-dev:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants