fish prompt: preserve pipestatus #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG: pypy dlls are named differently
Per the [changelog](https://github.com/pypa/virtualenv/blob/6d8a4ed81f40223a3f9ea1ba5d11be500d9f667a/docs/changes.rst) notes for `15.1.0`, Python 3.6 is supported. This change adds 3.6 to the trove classifiers and drops the now-unsupported 3.3.
Upgrade bundled dependencies
Upgrade pip to 9.0.3 and setuptools to 39.0.1
Drop support for Python 2.6
Upgrade bundled
"should filed" --> "should be filed"
…event failures on prompts. (pypa#1101)
Avoid running tests if rebuild-script is making repository dirty because this means that code was commited without rebuilding first. This prevents wasted time on reviews.
Be explicit about where `activate` is and maintain the convention used throughout.
Replaced pypi.python.org with pypi.org in the download URL. Added `-L` option to `curl` to follow redirects from randomized hash URLS. Also, replaced pypi.python.org/pypi with pypi.org/project throughout the docs. This fix addresses the most important part of pypa#1042.
* explain .gitignore * add documentations to tox.ini; python 3.7 to test envs * add coverage and timeout to tests * add pyproject.toml and isolated tox build
- now correctly detects current user installation and not just those installed at the system level - for Python versions 3.5+ (which track 32-bit & 64-bit installations separately), recognize version tags X.Y, X.Y-32 & X.Y-64 where X.Y represents the 64-bit installation if available or 32-bit otherwise
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
release 16.7.6
* bugfix: allow create env with no-pip * add changelog * add rst backticks
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
release 16.7.7
pypa/pip@09fd200 moved Pip's `main` function underneath a new `pip._internals.main` module. Playing a risky game, using `pip._internals`. ;-)
python 3.4 removed from macOS Azure Pipelines c.f. https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/macos/macos-10.14-Readme.md
Signed-off-by: Bernat Gabor <[email protected]>
From ``41.4.0`` to ``41.6.0`` Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
release 16.7.8
- also enable all PR triggers CI Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
release 16.7.9
The upcoming release fish 3.1.0 provides a variable $pipestatus, that exposes the exit code of each process in a pipeline. This $pipestatus is also used by the new default prompt. Presently, $status is restored but not $pipestatus, so a prompt displaying the pipestatus is wrong: expected: (env) $ false | true | false (env) [1|0|1] $ actual: (env) $ false | true | false (env) [0|1] $ The wrong $pipestatus is because `echo 'exit 1' | source` is used to restore the $status. This commit solves this problem more elegantly by running the user's prompt immediately, and printing it later. Uses the fish builtin "string" command which exists since fish 2.3b1 (released April 19, 2016) so that's unlikely to cause problems.
|
This should be done against the rewrite branch... The master branch soon goes to legacy. |
|
Whoops, that blew up when I changed the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming release fish 3.1.0 provides a variable $pipestatus, that
exposes the exit code of each process in a pipeline. This $pipestatus
is also used by the new default prompt.
Presently, $status is restored but not $pipestatus, so a prompt displaying
the pipestatus is wrong:
expected:
actual:
The wrong $pipestatus is because
echo 'exit 1' | sourceis usedto restore the $status.
This commit solves this problem more elegantly by running the user's
prompt immediately, and printing it later.
Uses the fish builtin "string" command which exists since fish 2.3b1
(released April 19, 2016) so that's unlikely to cause problems.
Thanks for contributing a pull request, see checklist all is good!
docs/changelogfolder