Reverse vendored wheel lookup order #1450
Conversation
|
A more robust way to go about it, if desired, would probably be to filter down the list of wheels to the highest version found. |
bskinn
force-pushed
the
py39
branch
5 times, most recently
from
bf965aa to
90f5c2f
Compare
azure-pipelines.yml
Outdated
| @@ -57,6 +61,23 @@ jobs: | |||
| with_toxenv: 'coverage' # generate .tox/.coverage, .tox/coverage.xml after test run | |||
| for_envs: [py37, py36, py35, py34, py27] | |||
|
|
|||
| - job: py39_linux | |||
There was a problem hiding this comment.
This should not be done here like this; instead, let's pull python 3.9 in via deadsnake at tox-dev/azure-pipelines-template@a7025f6
There was a problem hiding this comment.
please add the pr to tox-dev/azure-pipelines first please 👍
There was a problem hiding this comment.
Ah, I missed that!
It looks like the deadsnakes py39 is broken the same way, though -- it vendors a copy of pkg_resources that tries to work with collections.MutableMapping.
There was a problem hiding this comment.
And, nod, I figured this wasn't the right way to go about it, and would need to be integrated into the tox-dev template matrix, but I wanted to stand up a 3.9 job ASAP.
There was a problem hiding this comment.
please add the pr to tox-dev/azure-pipelines first please 👍
Not sure what you mean by this... should I just wait on this until that branch of tox-dev/azure-pipelines-template is merged?
There was a problem hiding this comment.
(that warning that shows up is annoying though, but I haven't figured out how to fix it quite yet -- low priority though since it appears to be harmless)
There was a problem hiding this comment.
@gaborbernat @asottile No idea why I'm getting a permissions error here: https://dev.azure.com/pypa/virtualenv/_build/results?buildId=15642
There was a problem hiding this comment.
some bug with tox's isolated builds? hard to tell -- might need to debug a bit -- have you been able to reproduce it locally?
There was a problem hiding this comment.
Haven't seriously tried yet -- my actual code change lets me create a virtualenv just fine now, locally; but, I haven't yet tried to run tox CI on 3.9. I'm frankly somewhat baffled as to what the correct sequence of steps is.
There was a problem hiding this comment.
Hah, really? just pip install -e . && tox -e py39? Boy, did I overthink that.
bskinn
force-pushed
the
py39
branch
11 times, most recently
from
3ad1d89 to
e1c399c
Compare
|
fwiw it ~mostly works locally: https://i.fluffy.cc/k8tXcF7knsqBwbr5zhrnwBK4Qmvmp9d6.html |
bskinn
force-pushed
the
py39
branch
3 times, most recently
from
151f66e to
2835217
Compare
|
Spent half an hour trying to figure out, but things are broken in too many places to be worth it (on my MacOs). I'll merge as it is to unblock other libraries, but probably python 3.9 support will only be fixed by the rewrite; unless someone is willing to spend a long time on this. |
gaborbernat
force-pushed
the
py39
branch
2 times, most recently
from
41de80c to
cba35c5
Compare
|
@gaborbernat I can confirm that the fix works for one of my repos, and @nedbat said that it worked for at least one of his. I think some of the problems will be resolved by having a fixed virtualenv version on PyPI, but things like the permissions error that's occurring when tox tries to build the package... I have no idea why it's happening on the deadsnakes Python but not the Azure-Task Pythons. |
Signed-off-by: Bernat Gabor <[email protected]>
|
Doing a release now 👍 |
|
@gaborbernat Eeep. I didn't draft a news fragment -- CHANGELOG doesn't reflect the change |
|
I've actually added one, committed just did not push 😆 oh well it's out now. |
|
Hehehe. Most people probably aren't testing py39 yet anyways...won't even notice the patch version bump. |
On cursory testing, appears to fix #1449 (pip execution error on virtualenv creation in python 3.9.0a1).
Rationale described here.
@gaborbernat, if you think this is sufficiently durable an approach, I can flesh out the PR. Not sure how to get it under CI, though, save with a full Python 3.9 build... looks like deadsnakes doesn't have 3.9 yet.
Thanks for contributing a pull request, see checklist all is good!
docs/changelogfolder