Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled #1205

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Upgrade bundled #1205

merged 1 commit into from
Oct 5, 2018

Conversation

asottile
Copy link
Contributor

CC @dstufft -- I based this on the work in #1176

Resolves #1179 (see #1179 (comment))

github (and git strangely enough) show setuptools as a "move" but they're not the same binary file:

$ git branch && sha256sum virtualenv_support/*.whl
* master
  update_bundled
717cdffb2833be8409433a93746744b59505f42146e8d37de6c62b430e25d6d7  virtualenv_support/pip-10.0.1-py2.py3-none-any.whl
0cb8b8625bfdcc2d43ea4b9cdba0b39b2b7befc04f3088897031082aa16ce186  virtualenv_support/setuptools-39.1.0-py2.py3-none-any.whl
80044e51ec5bbf6c894ba0bc48d26a8c20a9ba629f4ca19ea26ecfcf87685f5f  virtualenv_support/wheel-0.31.1-py2.py3-none-any.whl

$ git checkout update_bundled 
Switched to branch 'update_bundled'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)

$ git branch && sha256sum virtualenv_support/*.whl
  master
* update_bundled
070e4bf493c7c2c9f6a08dd797dd3c066d64074c38e9e8a0fb4e6541f266d96c  virtualenv_support/pip-18.0-py2.py3-none-any.whl
ce4137d58b444bac11a31d4e0c1805c69d89e8ed4e91fde1999674ecc2f6f9ff  virtualenv_support/setuptools-40.4.3-py2.py3-none-any.whl
80044e51ec5bbf6c894ba0bc48d26a8c20a9ba629f4ca19ea26ecfcf87685f5f  virtualenv_support/wheel-0.31.1-py2.py3-none-any.whl

Note that I made sure the sha256sum matches pypi:

$ curl -s https://pypi.org/simple/pip/ | grep 18.0-py2.py3 | grep -o sha256=[a-f0-9]*
sha256=070e4bf493c7c2c9f6a08dd797dd3c066d64074c38e9e8a0fb4e6541f266d96c
$ curl -s https://pypi.org/simple/setuptools/ | grep 40.4.3-py2.py3 | grep -o sha256=[a-f0-9]*
sha256=ce4137d58b444bac11a31d4e0c1805c69d89e8ed4e91fde1999674ecc2f6f9ff

@gaborbernat
Copy link
Contributor

Thanks!

@gaborbernat gaborbernat merged commit c185fc6 into pypa:master Oct 5, 2018
@asottile asottile deleted the update_bundled branch October 5, 2018 14:39
@asottile
Copy link
Contributor Author

asottile commented Oct 8, 2018

@gaborbernat any chance this can be made into a release?

@gaborbernat
Copy link
Contributor

will try on Wednesday

@asottile
Copy link
Contributor Author

asottile commented Oct 8, 2018

you da best

@asottile
Copy link
Contributor Author

(gentle nudge @gaborbernat <3)

@gaborbernat
Copy link
Contributor

I'm blocked for now on @dstufft. Hopefully the sprint this weekend will remove the blockers. For now though, it's delayed until I fix the CI (#1217). So I would say realistically next Wednesday is a more confident target. Sorry for the delays on this. By the next release, I hope things to be a bit more automatic, so things would move faster.

@asottile
Copy link
Contributor Author

Sounds great, thanks for all the work you're putting into this, it's greatly appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants