Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit for linting #331

Merged
merged 3 commits into from
Sep 3, 2021
Merged

chore: add pre-commit for linting #331

merged 3 commits into from
Sep 3, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 28, 2021

use pre-commit for linting.
We will be able to use pre-commit-ci to autocorrect pull requests for linting issues once this lands.

depends on #329 & #330

@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #331 (21a0db7) into master (e070c0e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   89.36%   89.35%   -0.01%     
==========================================
  Files          23       23              
  Lines        1204     1203       -1     
  Branches      254      255       +1     
==========================================
- Hits         1076     1075       -1     
  Misses         78       78              
  Partials       50       50              
Impacted Files Coverage Δ
auditwheel/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e070c0e...21a0db7. Read the comment docs.

@mayeut mayeut marked this pull request as ready for review September 2, 2021 21:06
@mayeut mayeut requested a review from lkollar September 2, 2021 21:06
@mayeut mayeut merged commit b2d597c into pypa:master Sep 3, 2021
@mayeut mayeut deleted the pre-commit5 branch September 3, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants