-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run black #329
chore: run black #329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 23 23
Lines 1204 1204
Branches 254 254
=======================================
Hits 1076 1076
Misses 78 78
Partials 50 50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also use a .git-blame-ignore-revs
file to ignore the commit in git blame
? See https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add black to the lint rule in tox.
This will be handled by #331 |
Depending how it'll be merged, the commit might change. better do this after it's merged. |
This file is used as a convention for commits to be ignored by bulk code changes. commit aa52a60 is such a commit (conversion to black code style). see pypa#329 (review) / https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
Reformat the code base with black.
It provides a known look & feel compared to other pypa projects (e.g. build, cibuildwheel, packaging, pip, ...)