-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use src
layout
#332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 23 23
Lines 1244 1244
Branches 270 270
=======================================
Hits 1114 1114
Misses 79 79
Partials 51 51
Continue to review full report at Codecov.
|
1e33bb3
to
e50abc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I can't figure out why the coverage has dropped so much. Any ideas @mayeut?
Taking a closer look at this, it seems all manylinux tests are skipped. I need to take a closer look to see what's wrong here... |
This now fixed and coverage is back to no diff which is expected. |
Allows better test isolation & thus, test the sdist / wheel without the legacy layout interfering.
depends on #331