Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use src layout #332

Merged
merged 3 commits into from
Sep 18, 2021
Merged

chore: use src layout #332

merged 3 commits into from
Sep 18, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 28, 2021

Allows better test isolation & thus, test the sdist / wheel without the legacy layout interfering.

depends on #331

@mayeut mayeut marked this pull request as draft August 28, 2021 17:51
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #332 (b4de8f4) into master (16b2e80) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          23       23           
  Lines        1244     1244           
  Branches      270      270           
=======================================
  Hits         1114     1114           
  Misses         79       79           
  Partials       51       51           
Impacted Files Coverage Δ
src/auditwheel/__main__.py 0.00% <ø> (ø)
src/auditwheel/condatools.py 91.66% <ø> (ø)
src/auditwheel/elfutils.py 94.05% <ø> (ø)
src/auditwheel/error.py 100.00% <ø> (ø)
src/auditwheel/genericpkgctx.py 50.00% <ø> (ø)
src/auditwheel/hashfile.py 100.00% <ø> (ø)
src/auditwheel/lddtree.py 87.17% <ø> (ø)
src/auditwheel/libc.py 87.50% <ø> (ø)
src/auditwheel/main.py 100.00% <ø> (ø)
src/auditwheel/main_addtag.py 86.84% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b2e80...b4de8f4. Read the comment docs.

@mayeut mayeut mentioned this pull request Aug 28, 2021
@mayeut mayeut force-pushed the src-layout branch 4 times, most recently from 1e33bb3 to e50abc6 Compare September 3, 2021 19:05
@mayeut mayeut marked this pull request as ready for review September 3, 2021 19:10
Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I can't figure out why the coverage has dropped so much. Any ideas @mayeut?

@mayeut
Copy link
Member Author

mayeut commented Sep 15, 2021

I can't figure out why the coverage has dropped so much. Any ideas @mayeut?

Taking a closer look at this, it seems all manylinux tests are skipped. I need to take a closer look to see what's wrong here...

@mayeut mayeut requested a review from lkollar September 18, 2021 06:42
@mayeut
Copy link
Member Author

mayeut commented Sep 18, 2021

I can't figure out why the coverage has dropped so much. Any ideas @mayeut?

Taking a closer look at this, it seems all manylinux tests are skipped. I need to take a closer look to see what's wrong here...

This now fixed and coverage is back to no diff which is expected.

@mayeut mayeut merged commit 82d8651 into pypa:master Sep 18, 2021
@mayeut mayeut deleted the src-layout branch September 18, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants