Check external dependencies versioned symbols

[mayeut]

This should fix #146
Uses a different mechanism compared to #148, it checks before producing the wheel.
It checks external dependencies versioned symbols when first analyzing the wheel ABI.

[takluyver]

Thanks! I tested this with pygame, and it appears to be working as expected. It's nicer than my solution in #148, because it fails before producing the erroneous manylinux wheel.

However, I'm having a hard time reading the code. I've put some suggestions inline for how I think it could be more readable. Or if someone smarter than me can read the code and sign off on it, I'm happy to defer to them. :-)

[takluyver]

Thanks - it's definitely getting clearer. I still struggle to follow it at the moment, but that's the peril of reviewing when I'm tired. I'll try to have a look tomorrow when I'm hopefully a bit more awake.

[mayeut]

@takluyver, I pushed 2 commits that should answer your comments

[takluyver]

Thanks, the comments really do help me understand what's going on.

There are some rather long lines there now. I'm not picky about any particular column limit, but some of these lines are definitely longer than is comfortably readable. Do you have time to reformat the code a bit? Or I can have a go at this if you prefer.

[takluyver]

Now #158 added a linter to the test suite, so we will need to stick to some column limit to satisfy that.

[mayeut]

I’ll rebase next week in order to get the linter checks

[mayeut]

I've rebased this PR on master, it now passes the lint check but I'm not quite happy with the type description of some variables. I don't know how to improve the readability of those comments, so feel free to comment on these.

[auvipy]

Conditionally approved for another round of review.

[lkollar]

I did a quick review, mostly on style and structure. I think refactoring the main logic into separate functions would also help with your type comments as you could move them into the doctstrings as example inputs, e.g:

def foo_func(thing: dict):
    """This function does X and Y.
         Parameters
         ----------
         thing : dict
            a thing to do stuff with
            Example input: {'/path/to/external_ref.so.1.2.3': 'external_ref.so.1'}
     """

[lkollar]

@auvipy I was going to review the changes. Why did you merge this? In the future could you wait until the person who requested changes approves the final version?

[auvipy]

OK sure.