Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AUDITWHEEL_PLAT environment variable as a default option to --plat #151

Merged
merged 2 commits into from
May 27, 2019
Merged

Use AUDITWHEEL_PLAT environment variable as a default option to --plat #151

merged 2 commits into from
May 27, 2019

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Apr 22, 2019

No description provided.

auvipy
auvipy requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to have tests

@mayeut
Copy link
Member Author

mayeut commented May 1, 2019

I'll add that

@mayeut mayeut force-pushed the plat-from-environ branch 2 times, most recently from e8711ac to ae31480 Compare May 1, 2019 13:19
@mayeut
Copy link
Member Author

mayeut commented May 1, 2019

I've reworked that a bit with inspiration from how twine does it.
I'll add more tests once #150 is merged-in (or at least the test commit)

takluyver
takluyver reviewed May 7, 2019
View reviewed changes
tests/helpers.py Outdated Show resolved Hide resolved
@mayeut mayeut requested a review from auvipy May 26, 2019 18:23
@takluyver
Copy link
Member

@mayeut I'm happy to merge this. You mentioned before you were waiting for #150. Do you want to get that one in first, in case there are any odd interactions between them? It seems unlikely, but if there are, I guess it's easy to tidy them up in this simpler change.

@auvipy auvipy merged commit c6ff475 into pypa:master May 27, 2019
@mayeut
Copy link
Member Author

mayeut commented May 27, 2019

I'll add some more tests (integration) in a different PR

@mayeut mayeut deleted the plat-from-environ branch May 27, 2019 19:30
@matthew-brett matthew-brett mentioned this pull request Jun 7, 2019
Closed
@matthew-brett matthew-brett mentioned this pull request Jul 17, 2019
Closed
@takluyver takluyver mentioned this pull request Jul 18, 2019
Closed
@vyasr vyasr mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takluyver takluyver takluyver left review comments

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayeut @takluyver @auvipy