Run linter in test suite #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds flake8 to tox to lint the code base.
|
No idea why Travis is failing. It seems to just stall on some builds and then time out. |
|
According to the status page Travis is having issues with Docker builds. A fix is being implemented at the moment. Will retry the build once they confirm the issue is fixed. |
These are necessary to make the lint check pass. There should be no changes in program logic.
|
Travis rolled out the fix to the Docker build issue and the build is passing now. |
auvipy
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
flake8totoxto lint the code base and fixes the current lint errors to make the tests pass.Closes: #115