Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async/await keywords in test_server_asyncio.py #534

Merged
merged 3 commits into from
Dec 30, 2020

Conversation

JamesJeffryes
Copy link

I'm planning on splitting up a fix to #513 & #467 into a couple of PRs as there's more edits than I expected.

While I was replacing the old async syntax, I took a moment to do some reformatting, remove unused imports and replace the unittest methods with pytest syntax.

@dhoomakethu
Copy link
Contributor

@JamesJeffryes Thanks for the PR, looks like this is breaking tests in all other python versions except 3.8. Would you be able to take a look please ?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
13.3% 13.3% Duplication

@JamesJeffryes
Copy link
Author

Fixed most of the other builds by specifying a minimum version of 'attrs' but the xcode tests looks like they are timing out trying to install java. Maybe there's a more modern image that could be used?

@JamesJeffryes
Copy link
Author

More general question, if this code is bound for a 3.5+ release. Should I pull out the IS_PYTHON3 checking in the tests as I go?

@JamesJeffryes
Copy link
Author

@dhoomakethu Thoughts on the failing xcode build?

@dhoomakethu
Copy link
Contributor

Will take a look, osx builds are failing off late. Could be the xcode version that is causing the issue.

@JamesJeffryes JamesJeffryes changed the base branch from dev to 3.0.0 December 21, 2020 12:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhoomakethu dhoomakethu merged commit 7f9eebe into pymodbus-dev:3.0.0 Dec 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants