-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use async/await keywords in test_server_asyncio.py #534
Conversation
@JamesJeffryes Thanks for the PR, looks like this is breaking tests in all other python versions except 3.8. Would you be able to take a look please ? |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Fixed most of the other builds by specifying a minimum version of 'attrs' but the xcode tests looks like they are timing out trying to install java. Maybe there's a more modern image that could be used? |
More general question, if this code is bound for a 3.5+ release. Should I pull out the IS_PYTHON3 checking in the tests as I go? |
@dhoomakethu Thoughts on the failing xcode build? |
Will take a look, osx builds are failing off late. Could be the xcode version that is causing the issue. |
Kudos, SonarCloud Quality Gate passed! |
I'm planning on splitting up a fix to #513 & #467 into a couple of PRs as there's more edits than I expected.
While I was replacing the old async syntax, I took a moment to do some reformatting, remove unused imports and replace the unittest methods with pytest syntax.