Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated coroutine #467

Closed
albireox opened this issue Nov 11, 2019 · 3 comments
Closed

Deprecated coroutine #467

albireox opened this issue Nov 11, 2019 · 3 comments

Comments

@albireox
Copy link

Versions

  • Python: 3.8
  • OS: macOS 10.15
  • Pymodbus: 2.3.0
  • Modbus Hardware (if used): WAGO

Pymodbus Specific

  • Client: tcp - async

Description

Trying to import from pymodbus.client.asynchronous.asyncio import AsyncioModbusTcpClient produces a series of messages [WARNING]: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead (DeprecationWarning). Python 3.8 has deprecated the coroutine decorator. Also, there is a filter in pymodbus that always shows these warnings so it's not possible to suppress them.

@dhoomakethu dhoomakethu added this to the 2.4.0 milestone Dec 1, 2019
@JamesJeffryes
Copy link

@dhoomakethu I'm happy to open a PR to address this. One thing to note is that converting to use of the async keyword would limit the library to 3.5+ but that seems like a pretty reasonable limitation to me.

@dhoomakethu
Copy link
Contributor

Yes, pymodbus 3 would be only available for Python 3.5 and above and it should be good to have that change. Feel free to raise a PR

@swamper123
Copy link
Collaborator

This was cleaned up with #564 .
At least I couldn't find any decorator.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants