-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 support? #544
Comments
Update from ubuntu xenial(16.04) to bionic(18.04) Mentioned issue in pymodbus-dev#544
Python2 support will be removed from pymodbus 3.x onwards. JFYI. |
Thanks for the information. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
With the new default branch 3.0.0 and #564 merged, this issue is solved. |
Versions
Description
I haven't found in the Readme, which Python versions shall be supported here ("it should work fine under any python version > 2.7 (including python 3+)").
Python 2 is dead since this year (and may have been dead a long time ago, I mean the lifecycle was more than 9 years), so there won't be more fixes, it will just cause more problems to be compatible with future Python versions.
There been have many things happening in the Python 3 world as well, esepcially in the async section with Python3.6.
Being compatible across these worlds makes the code more complex, slower and unsafer, especially if the Python3 developement goes on.
I would recommened to drop support for all Python versions <3.6 (or even start with 3.7 and go up to 3.9) and explicit mention that in the README.
EDIT: This log from Travis will also may cause problems in the near future as well:
EDIT: If that PR may clear where we are going with versions, I guess #513 and #534 can be tackled as well
Funfact: Python3 support was added ~7years ago for this library
The text was updated successfully, but these errors were encountered: