Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support? #544

Closed
swamper123 opened this issue Oct 15, 2020 · 5 comments
Closed

Drop Python 2 support? #544

swamper123 opened this issue Oct 15, 2020 · 5 comments

Comments

@swamper123
Copy link
Collaborator

swamper123 commented Oct 15, 2020

Versions

  • Python: >=3.6
  • Pymodbus: >= 2.4

Description

I haven't found in the Readme, which Python versions shall be supported here ("it should work fine under any python version > 2.7 (including python 3+)").

Python 2 is dead since this year (and may have been dead a long time ago, I mean the lifecycle was more than 9 years), so there won't be more fixes, it will just cause more problems to be compatible with future Python versions.
There been have many things happening in the Python 3 world as well, esepcially in the async section with Python3.6.

Being compatible across these worlds makes the code more complex, slower and unsafer, especially if the Python3 developement goes on.

I would recommened to drop support for all Python versions <3.6 (or even start with 3.7 and go up to 3.9) and explicit mention that in the README.

EDIT: This log from Travis will also may cause problems in the near future as well:

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

EDIT: If that PR may clear where we are going with versions, I guess #513 and #534 can be tackled as well

Funfact: Python3 support was added ~7years ago for this library

swamper123 pushed a commit to swamper123/pymodbus that referenced this issue Oct 15, 2020
Update from ubuntu xenial(16.04) to bionic(18.04)
Mentioned issue in pymodbus-dev#544
@dhoomakethu
Copy link
Contributor

Python2 support will be removed from pymodbus 3.x onwards. JFYI.

@swamper123
Copy link
Collaborator Author

Thanks for the information.
I will start some cleanup PRs already ;)

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue was closed because it has been stalled for 5 days with no activity.

@swamper123
Copy link
Collaborator Author

With the new default branch 3.0.0 and #564 merged, this issue is solved.
Case closed. 🕵️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants