-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run black on distributions/ and */__init__.py #4139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @aliakbars !
Files pymc3/distributions/discrete.py , pymc3/distributions/multivariate.py , and pymc3/step_methods/metropolis.py are huge - could they be done is a separate pull request?
Codecov Report
@@ Coverage Diff @@
## master #4139 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 89 89
Lines 14037 14024 -13
=======================================
- Hits 12457 12446 -11
+ Misses 1580 1578 -2
|
Co-authored-by: Marco Gorelli <[email protected]>
Certainly. Should I create one pull request for each of them? @MarcoGorelli |
I'd suggest a single PR for those 3 |
Thanks for the PR @aliakbars ! Regarding the tests failure, it seems like pylint is complaining: https://travis-ci.org/github/pymc-devs/pymc3/jobs/730683202#L2215 |
My bad, @AlexAndorra. Must have pressed something accidentally while viewing the code. It has passed the CI as well now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @aliakbars !
xref #4109