Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run black on distributions/ and */__init__.py #4139

Merged
merged 7 commits into from
Sep 29, 2020

Conversation

aliakbars
Copy link
Contributor

xref #4109

Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @aliakbars !

Files pymc3/distributions/discrete.py , pymc3/distributions/multivariate.py , and pymc3/step_methods/metropolis.py are huge - could they be done is a separate pull request?

pymc3/distributions/bound.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #4139 into master will increase coverage by 0.00%.
The diff coverage is 72.41%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4139   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files          89       89           
  Lines       14037    14024   -13     
=======================================
- Hits        12457    12446   -11     
+ Misses       1580     1578    -2     
Impacted Files Coverage Δ
pymc3/distributions/simulator.py 85.48% <ø> (ø)
pymc3/distributions/transforms.py 97.70% <ø> (+0.25%) ⬆️
pymc3/stats/__init__.py 92.00% <ø> (ø)
pymc3/step_methods/sgmcmc.py 0.00% <0.00%> (ø)
pymc3/plots/__init__.py 50.00% <8.33%> (ø)
pymc3/step_methods/gibbs.py 40.00% <40.00%> (ø)
pymc3/step_methods/hmc/integration.py 89.79% <50.00%> (ø)
pymc3/step_methods/elliptical_slice.py 95.12% <66.66%> (ø)
pymc3/step_methods/hmc/hmc.py 92.15% <77.77%> (ø)
pymc3/step_methods/hmc/nuts.py 97.46% <90.00%> (ø)
... and 13 more

@aliakbars
Copy link
Contributor Author

aliakbars commented Sep 27, 2020

Nice, thanks @aliakbars !

Files pymc3/distributions/discrete.py , pymc3/distributions/multivariate.py , and pymc3/step_methods/metropolis.py are huge - could they be done is a separate pull request?

Certainly. Should I create one pull request for each of them? @MarcoGorelli

@MarcoGorelli
Copy link
Contributor

I'd suggest a single PR for those 3

@AlexAndorra
Copy link
Contributor

AlexAndorra commented Sep 28, 2020

Thanks for the PR @aliakbars ! Regarding the tests failure, it seems like pylint is complaining: https://travis-ci.org/github/pymc-devs/pymc3/jobs/730683202#L2215

@aliakbars
Copy link
Contributor Author

aliakbars commented Sep 28, 2020

My bad, @AlexAndorra. Must have pressed something accidentally while viewing the code. It has passed the CI as well now.

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @aliakbars !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants