-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply black formatter #4109
Comments
I'd like to help on this. Are there prioritised files? |
@aliakbars that's great! I don't think there's any prioritisation, no |
@MarcoGorelli Will the above checklist get updates automatically? |
Nope, been doing it manually do far |
Hi, I'd like to help.. I'm working on :
|
Hi @AlexAndorra - it looks like linking the issue resulted in this being closed then #4150 was merged - could it stay open until there's a pre-commit / CI check in place? |
Ah yes, I thought it was done -- reopened 😉 |
xref #4108 (comment)
Reviewing PRs which change code and change formatting can be tricky, so my suggestion is to apply
black
to batches of 10-15 files at a time, merge those in, and then addblack
to.pre-commit-config.yaml
.This would make for a good beginner-friendly issue. Make sure you're using
black
version 20.8b1 for this.See #4110 for an example of how to open a PR for this
EDIT
have removed the list of files as it looks like existing PRs might be enough to close this off. Please see #4095 for a similar issue to tackle
EDIT2
As of 2020-10-08, existing PRs should be enough to address all files. To close this issue, a pre-commit hook should be added
The text was updated successfully, but these errors were encountered: