Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black formatter #4109

Closed
MarcoGorelli opened this issue Sep 18, 2020 · 7 comments · Fixed by #4150 or #4163
Closed

Apply black formatter #4109

MarcoGorelli opened this issue Sep 18, 2020 · 7 comments · Fixed by #4150 or #4163

Comments

@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Sep 18, 2020

xref #4108 (comment)

Reviewing PRs which change code and change formatting can be tricky, so my suggestion is to apply black to batches of 10-15 files at a time, merge those in, and then add black to .pre-commit-config.yaml.

This would make for a good beginner-friendly issue. Make sure you're using black version 20.8b1 for this.

See #4110 for an example of how to open a PR for this

EDIT

have removed the list of files as it looks like existing PRs might be enough to close this off. Please see #4095 for a similar issue to tackle

EDIT2

As of 2020-10-08, existing PRs should be enough to address all files. To close this issue, a pre-commit hook should be added

@aliakbars
Copy link
Contributor

I'd like to help on this. Are there prioritised files?

@MarcoGorelli
Copy link
Contributor Author

@aliakbars that's great! I don't think there's any prioritisation, no

@aliakbars
Copy link
Contributor

@MarcoGorelli Will the above checklist get updates automatically?

@MarcoGorelli
Copy link
Contributor Author

Nope, been doing it manually do far

@satrio-hw
Copy link
Contributor

satrio-hw commented Sep 28, 2020

Hi, I'd like to help.. I'm working on :

  • pymc3/tests/test_shape_handling.py
  • pymc3/tests/test_ode.py
  • pymc3/tests/test_text_backend.py
  • pymc3/tests/test_tracetab.py
  • pymc3/tests/test_tuning.py
  • pymc3/tests/test_quadpotential.py
  • pymc3/tests/test_updates.py
  • pymc3/tests/test_types.py
  • pymc3/tests/test_mixture.py
  • pymc3/tests/test_util.py

@MarcoGorelli
Copy link
Contributor Author

Hi @AlexAndorra - it looks like linking the issue resulted in this being closed then #4150 was merged - could it stay open until there's a pre-commit / CI check in place?

@AlexAndorra
Copy link
Contributor

Ah yes, I thought it was done -- reopened 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants