Formatted Remaining 22 Files #4161
Conversation
|
@AlexAndorra and @MarcoGorelli Please Review. |
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 89 89
Lines 14039 14039
=======================================
Hits 12461 12461
Misses 1578 1578
|
pymc3/theanof.py
Outdated
| @@ -368,8 +367,7 @@ def set_default(self, value): | |||
| t1 = (False,) * value.ndim | |||
| t2 = self.generator.tensortype.broadcastable | |||
| if not t1 == t2: | |||
| raise ValueError('Default value should have the ' | |||
| 'same type as generator') | |||
| raise ValueError("Default value should have the " "same type as generator") | |||
There was a problem hiding this comment.
| raise ValueError("Default value should have the " "same type as generator") | |
| raise ValueError("Default value should have the same type as generator") |
| ' is zero.'.format(*name_slc[ii])) | ||
| raise ValueError('\n'.join(errmsg)) | ||
| errmsg.append( | ||
| "The derivative of RV `{}`.ravel()[{}]" " is zero.".format(*name_slc[ii]) |
There was a problem hiding this comment.
| "The derivative of RV `{}`.ravel()[{}]" " is zero.".format(*name_slc[ii]) | |
| "The derivative of RV `{}`.ravel()[{}] is zero.".format(*name_slc[ii]) |
| ' is non-finite.'.format(*name_slc[ii])) | ||
| raise ValueError('\n'.join(errmsg)) | ||
| errmsg.append( | ||
| "The derivative of RV `{}`.ravel()[{}]" " is non-finite.".format(*name_slc[ii]) |
There was a problem hiding this comment.
| "The derivative of RV `{}`.ravel()[{}]" " is non-finite.".format(*name_slc[ii]) | |
| "The derivative of RV `{}`.ravel()[{}] is non-finite.".format(*name_slc[ii]) |
pymc3/tests/test_distributions.py
Outdated
| ( | ||
| None, | ||
| 0.5, | ||
| None, | ||
| None, | ||
| "Incompatible parametrization. Must specify either alpha or n.", | ||
| ), | ||
| ( | ||
| None, | ||
| None, | ||
| None, | ||
| None, | ||
| "Incompatible parametrization. Must specify either alpha or n.", | ||
| ), |
There was a problem hiding this comment.
Can you change L834 so that it reads
with pytest.raises(ValueError, match=f"Incompatible parametrization. {expected}"):and then "Incompatible parametrization." can be removed from here (and from the remaining tuples from this particular test):
(None, None, None, None, "Must specify either alpha or n."),and black will keep this on one line.
You'll then need to run pytest pymc3/tests/test_distributions.py -k test_negative_binomial_init_fail to check that this still passes
If you decide to do this, please comment in the PR description that you've made this change. In general it's good to keep formatting separate from changing code (this way it's easier to review / revert), but IMO here it's a really simple change and it allows the formatting to be applied more cleanly so it's OK
|
@MarcoGorelli Please Review |
In Issue #4109 Formatted 22 Remaining Files