Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied Formatting using Black Command on 13 files #4144

Closed
wants to merge 5 commits into from
Closed

Applied Formatting using Black Command on 13 files #4144

wants to merge 5 commits into from

Conversation

Yash1256
Copy link
Contributor

@Yash1256 Yash1256 commented Sep 28, 2020

Issue #4109 Applied Formatting Using black Command and After That run pre-commit run pyupgrade --all to all the files.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #4144 into master will decrease coverage by 0.00%.
The diff coverage is 76.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4144      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.01%     
==========================================
  Files          89       89              
  Lines       14037    14024      -13     
==========================================
- Hits        12458    12446      -12     
+ Misses       1579     1578       -1     
Impacted Files Coverage Δ
pymc3/math.py 68.47% <0.00%> (ø)
pymc3/plots/posteriorplot.py 21.05% <0.00%> (ø)
pymc3/ode/ode.py 93.75% <70.58%> (ø)
pymc3/parallel_sampling.py 88.36% <75.00%> (ø)
pymc3/gp/util.py 80.00% <80.00%> (ø)
pymc3/model_graph.py 88.48% <80.76%> (ø)
pymc3/gp/cov.py 97.96% <100.00%> (ø)
pymc3/gp/mean.py 97.43% <100.00%> (ø)
pymc3/memoize.py 96.15% <100.00%> (ø)
pymc3/ode/utils.py 100.00% <100.00%> (ø)
... and 5 more

@Yash1256 Yash1256 closed this Sep 28, 2020
@Yash1256 Yash1256 deleted the black_15_files branch September 28, 2020 13:40
@MarcoGorelli
Copy link
Contributor

@Yash1256 this looked like it was on the right track

@Yash1256
Copy link
Contributor Author

@MarcoGorelli Sir it was my bad actually I should make a 15 files in a one commit but after that I applied the black in more than 15 files so quite difficult to analyze the pr from your side, thereby closed the pr. I will again open this pr and made all the changes in the patch of 15 files.

@MarcoGorelli
Copy link
Contributor

sure, no hurry, feel free to ping me if you want/need help

@MarcoGorelli
Copy link
Contributor

and After That run pre-commit run pyupgrade --all to all the files.

I think you would just need to do pre-commit run, so that the code quality checks are only applied to the files you've staged

@Yash1256
Copy link
Contributor Author

@MarcoGorelli Thanks Sir I will Sure come up with the right pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants