Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily load resource files #4297

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Lazily load resource files #4297

merged 2 commits into from
Aug 2, 2020

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky self-assigned this Aug 1, 2020
shoyer
shoyer approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @crusaderky !

xarray/core/formatting_html.py
Comment on lines 1 to 4
import uuid
from collections import OrderedDict
from functools import partial
from functools import lru_cache, partial
from html import escape
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort seems to be complaining now

@crusaderky crusaderky merged commit f99c6cc into pydata:master Aug 2, 2020
@crusaderky crusaderky deleted the lazy_static branch August 2, 2020 07:05
dcherian added a commit to rpgoldman/xarray that referenced this pull request Aug 14, 2020
@dcherian
Merge branch 'master' of github.com:pydata/xarray into drop-vars-doc
f648f41 
* 'master' of github.com:pydata/xarray: (260 commits)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  Fix docstring for missing_dims argument to isel methods (pydata#4298)
  Support for PyCharm remote deployment (pydata#4299)
  Update map_blocks and map_overlap docstrings (pydata#4303)
  Lazily load resource files (pydata#4297)
  warn about the removal of the ufuncs (pydata#4268)
  ...
This was referenced Sep 20, 2020
Closed
Closed
@richardARPANET
Copy link

richardARPANET commented Sep 21, 2020 •
edited
Loading

FYI this is a breaking API change yet you have not bumped the version number correctly for the most recent release. (It should be a MAJOR version bump if you're using semver).

@dcherian dcherian mentioned this pull request Sep 21, 2020
Closed
@dcherian
Copy link
Contributor

Sorry for the trouble but xr.core.formatting_html.CSS_STYLE is definitely not public API. Quoting https://xarray.pydata.org/en/stable/faq.html#what-parts-of-xarray-are-considered-public-api

Everything else (in particular, everything in xarray.core that is not also exposed in the top level xarray namespace) is considered a private implementation detail that may change at any time.

@richardARPANET
Copy link

Sure, but people are using it so it sort of is :) Next time, to signal to people something should not be used, the variable should start with an underscore _.

@shoyer shoyer mentioned this pull request Sep 22, 2020
Closed
@shoyer
Copy link
Member

shoyer commented Sep 22, 2020

It looks like we inadvertently broke arViz here: #4447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyInstaller executable which packages xarray throws an error when executable is run
4 participants
@crusaderky @richardARPANET @dcherian @shoyer