Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS_STYLE attribute breaking packages #4447

Closed
Horndev opened this issue Sep 22, 2020 · 4 comments
Closed

CSS_STYLE attribute breaking packages #4447

Horndev opened this issue Sep 22, 2020 · 4 comments

Comments

@Horndev
Copy link

Horndev commented Sep 22, 2020

The latest version has breaking changes for other packages. I would not expect this from a minor version increment.

For arviz:

  File "/usr/local/lib/python3.6/site-packages/arviz/utils.py", line 670, in <module>
    class HtmlTemplate:
  File "/usr/local/lib/python3.6/site-packages/arviz/utils.py", line 696, in HtmlTemplate
    css_template = f"<style> {xr.core.formatting_html.CSS_STYLE}{specific_style} </style>"
AttributeError: module 'xarray.core.formatting_html' has no attribute 'CSS_STYLE'
@shoyer
Copy link
Member

shoyer commented Sep 22, 2020

xref #4297 (comment), arviz-devs/arviz#1387

xarray.core is not part of our public API. I can see why this could be confusing -- the modules does not use Python's standard underscore prefix -- but this is a fairly well established convention in the scientific Python ecosystem, e.g., you shouldn't rely upon imports from pandas.core or numpy.core either.

@nathdip
Copy link

nathdip commented Sep 23, 2020

What is the solution to this issue again? Should I downgrade either arviz or xarray?

@max-sixty
Copy link
Collaborator

There are a few options over at arviz-devs/arviz#1387 — either downgrade xarray or upgrade arviz to master

@nathdip
Copy link

nathdip commented Sep 23, 2020

Thanks for the help, that worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants