Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase support window of all dependencies #4296

Merged
merged 9 commits into from
Aug 14, 2020
Merged

Increase support window of all dependencies #4296

merged 9 commits into from
Aug 14, 2020

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Aug 1, 2020 •
edited
Loading

Closes #4295

Increase width of the sliding window for minimum supported version:

  • setuptools from 6 months sliding window to hardcoded >= 38.4, and to 42 months sliding window starting from July 2021
  • dask and distributed from 6 months sliding window to hardcoded >= 2.9, and to 12 months sliding window starting from January 2021
  • all other libraries from 6 months to 12 months sliding window

@ChrisBarker-NOAA ChrisBarker-NOAA mentioned this pull request Aug 1, 2020
Closed
@crusaderky crusaderky closed this Aug 1, 2020
@crusaderky crusaderky reopened this Aug 1, 2020
@crusaderky crusaderky mentioned this pull request Aug 1, 2020
Closed
@crusaderky crusaderky requested a review from shoyer August 1, 2020 21:33
@crusaderky crusaderky self-assigned this Aug 2, 2020
@jthielen jthielen mentioned this pull request Aug 5, 2020
Open
@keewis keewis mentioned this pull request Aug 5, 2020
Merged
@max-sixty
Copy link
Collaborator

Thanks @crusaderky , LGTM

To confirm, this is still "the oldest version released within the time period", rather than "the version that existed at the start of the time period"

(which as discussed in other threads is a bit odd, but that's what numpy does so...)

@crusaderky
Copy link
Contributor Author

To confirm, this is still "the oldest version released within the time period", rather than "the version that existed at the start of the time period"

Yes, this hasn't changed.

@crusaderky crusaderky closed this Aug 12, 2020
@crusaderky crusaderky reopened this Aug 12, 2020
@max-sixty
Copy link
Collaborator

I'm guessing the docs failure is unrelated — I can't see why this would be affected and there doesn't seem to be any error in the logs. Does that sound right?

@crusaderky
Copy link
Contributor Author

@max-sixty definitely unrelated

@keewis
Copy link
Collaborator

keewis commented Aug 12, 2020

the failing docs CI is indeed unrelated and will be fixed by #4286

@max-sixty max-sixty self-requested a review August 12, 2020 13:13
max-sixty
max-sixty approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shoyer
shoyer approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement. Thanks @crusaderky.

@keewis keewis closed this Aug 13, 2020
@keewis keewis reopened this Aug 13, 2020
@keewis keewis closed this Aug 13, 2020
@keewis keewis reopened this Aug 13, 2020
@keewis
Copy link
Collaborator

keewis commented Aug 13, 2020

support set a feature flag, so now RTD appends to our environment file instead of executing multiple install commands. That means version pinning of sphinx works and the docs CI should hopefully pass.

@shoyer
Copy link
Member

shoyer commented Aug 13, 2020

support set a feature flag, so now RTD appends to our environment file instead of executing multiple install commands. That means version pinning of sphinx works and the docs CI should hopefully pass.

Awesome, thanks for digging in here! Multiple install commands in RTD has been persistently very painful / error-prone.

@crusaderky crusaderky merged commit 8fab5a2 into pydata:master Aug 14, 2020
@crusaderky crusaderky deleted the relax_minversions branch August 14, 2020 09:52
dcherian added a commit to rpgoldman/xarray that referenced this pull request Aug 14, 2020
@dcherian
Merge branch 'master' of github.com:pydata/xarray into drop-vars-doc
f648f41 
* 'master' of github.com:pydata/xarray: (260 commits)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  Fix docstring for missing_dims argument to isel methods (pydata#4298)
  Support for PyCharm remote deployment (pydata#4299)
  Update map_blocks and map_overlap docstrings (pydata#4303)
  Lazily load resource files (pydata#4297)
  warn about the removal of the ufuncs (pydata#4268)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 15, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into propagate-attrs
b86623c 
* upstream/master: (34 commits)
  Fix bug in computing means of cftime.datetime arrays (pydata#4344)
  fix some str accessor inconsistencies (pydata#4339)
  pin matplotlib in ci/requirements/doc.yml (pydata#4340)
  Clarify drop_vars return value. (pydata#4244)
  Support explicitly setting a dimension order with to_dataframe() (pydata#4333)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  ...
@mathause mathause mentioned this pull request Aug 16, 2020
Closed
1 task
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 16, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
1ea8666 
* upstream/master: (40 commits)
  Fix bug in computing means of cftime.datetime arrays (pydata#4344)
  fix some str accessor inconsistencies (pydata#4339)
  pin matplotlib in ci/requirements/doc.yml (pydata#4340)
  Clarify drop_vars return value. (pydata#4244)
  Support explicitly setting a dimension order with to_dataframe() (pydata#4333)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@shoyer shoyer shoyer approved these changes

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We shouldn't require a recent version of setuptools to install xarray
4 participants
@crusaderky @max-sixty @keewis @shoyer