Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing docs CI #4287

Closed
keewis opened this issue Jul 29, 2020 · 4 comments · Fixed by #4316
Closed

failing docs CI #4287

keewis opened this issue Jul 29, 2020 · 4 comments · Fixed by #4316

Comments

@keewis
Copy link
Collaborator

keewis commented Jul 29, 2020

I'm not quite sure why (maybe a pandas or matplotlib release?), but the docs CI raises a exception in plotting.rst:

xarray/doc/plotting.rst

Lines 589 to 590 in a081d01

@savefig plot_facet_dataarray.png
g_simple = t.plot(x="lon", y="lat", col="time", col_wrap=3)

there are also sphinx warnings about malformed rst:

/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/4286/lib/python3.8/site-packages/pandas/core/base.py:docstring of xarray.CFTimeIndex.max:7: WARNING: Inline strong start-string without end-string.
/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/4286/lib/python3.8/site-packages/pandas/core/base.py:docstring of xarray.CFTimeIndex.min:7: WARNING: Inline strong start-string without end-string.

so I guess there was a pandas release a few days ago?

Edit: pandas 1.1.0 was released yesterday

@keewis
Copy link
Collaborator Author

keewis commented Jul 30, 2020

I can confirm that downgrading fixes the build. Not sure what changed, but we should try to extend our plotting tests so we can catch this using the upstream-dev CI.

@dopplershift
Copy link
Contributor

The exception looks like the identical problem as #4283 .

@keewis
Copy link
Collaborator Author

keewis commented Jul 30, 2020

thanks, @dopplershift, the exception does indeed look like #4283.

The warnings are a sphinx bug (see sphinx-doc/sphinx#7799), but it will probably take some time until the release of sphinx 3.2.0. I guess that means we have to live with these warnings until then? We could use suppress_warnings, but that would ignore all warnings about invalid formatting.

@crusaderky
Copy link
Contributor

Temporarily pinning pandas=1.0 in #4296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants