Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v24.11.0 #4598

Merged
merged 175 commits into from
Nov 21, 2024
Merged

Release v24.11.0 #4598

merged 175 commits into from
Nov 21, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Nov 20, 2024

Release branch for 24.11.0

Wheels where built here: kratman#5

valentinsulzer and others added 10 commits November 12, 2024 11:05
* Error message fix

* Fix logging error

* Remove blank line
…4562)

* add error and test

* disable thermal half cells for now

* easier way to fix it

* clean up

* move half cell code to function

* style: pre-commit fixes

* changelog

* Update CHANGELOG.md

Co-authored-by: Eric G. Kratz <[email protected]>

---------

Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: Alexander Bills <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Bump to latest baseline (CasADi 3.6.7)

* Bump host and runtime version for CasADi
Bumps the actions group with 2 updates: [codecov/codecov-action](https://github.com/codecov/codecov-action) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `codecov/codecov-action` from 4.6.0 to 5.0.2
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.6.0...v5.0.2)

Updates `github/codeql-action` from 3.27.1 to 3.27.4
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4f3212b...ea9e4e3)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.3 → v0.7.4](astral-sh/ruff-pre-commit@v0.7.3...v0.7.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…up_and_parameterise_experiment` made private in `simulation.py` (#4489)

* Fix: Add deprecated warning for `set_up_and_parameterise_model_for_experiment` in simulation

* Add deprecated warning for `set_parameters` in simulation

* Docs: Add deprecated message in unreleased section

* style: pre-commit fixes

* Docs: Move deprecated to Breaking changes section

* Fix: Make set_up_and_parameterise_experiment private

* Fix: Make set_paramters func private

* Refactor: Add deprecation warning message in set_parameters() func

* Refactor: Add deprecation warning in `set_up_and_parameterise_experiment` func

* Fix some typos

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: kratman <[email protected]>
* Reorganize to make sure capture does not run

* Cleanup

* Mock telemetry object

* Fix logic

* Minor fixes for networking

* temporary trigger

* testing env

* Remove requirement

* Try again

* Last attempt

* Update wheel env

* Cleanup

* More cleanup

* Final test for cleanup

* Turn off wheel build

* Make sure opt out is in all tests

* Fix some coverage

* Cover last line

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kratman kratman self-assigned this Nov 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kratman kratman marked this pull request as ready for review November 20, 2024 23:25
@kratman kratman changed the title V24.11.0 Release v24.11.0 Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 99.73136% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.25%. Comparing base (1ab27d1) to head (97a37fd).
Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
src/pybamm/simulation.py 90.62% 3 Missing ⚠️
...els/submodels/particle_mechanics/base_mechanics.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4598      +/-   ##
==========================================
- Coverage   99.42%   99.25%   -0.18%     
==========================================
  Files         292      302      +10     
  Lines       22215    22906     +691     
==========================================
+ Hits        22087    22735     +648     
- Misses        128      171      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Eric!

@kratman kratman merged commit 5b1ef70 into main Nov 21, 2024
43 of 45 checks passed
@kratman kratman deleted the v24.11.0 branch November 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.