Misc. bug fixes #4581
Merged
Misc. bug fixes #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratman
requested review from
a team,
brosaplanella,
DrSOKane,
rtimms,
valentinsulzer and
TomTranter
as code owners
kratman
commented
Nov 12, 2024
| @@ -243,7 +243,7 @@ def update(self, values, check_conflict=False, check_already_exists=True, path=" | |||
| f"Cannot update parameter '{name}' as it does not " | |||
| + f"have a default value. ({err.args[0]}). If you are " | |||
| + "sure you want to update this parameter, use " | |||
| + "param.update({{name: value}}, check_already_exists=False)" | |||
| + "param.update({name: value}, check_already_exists=False)" | |||
There was a problem hiding this comment.
This was a mistake from when the f-strings were broken up
| @@ -234,4 +235,4 @@ | |||
| "pybamm_data", | |||
| ] | |||
|
|
|||
| pybamm.config.generate() | |||
| config.generate() | |||
There was a problem hiding this comment.
Doing it this way gets rid of an IDE warning
| _posthog = Posthog( | ||
| # this is the public, write only API key, so it's ok to include it here | ||
| project_api_key="phc_bLZKBW03XjgiRhbWnPsnKPr0iw0z03fA6ZZYjxgW7ej", | ||
| host="https://us.i.posthog.com", | ||
| ) | ||
|
|
||
| _posthog.log.setLevel("CRITICAL") |
There was a problem hiding this comment.
The error from not being connected to the internet comes out at the ERROR level. This stops the warning as far as I can tell
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4581 +/- ##
========================================
Coverage 99.27% 99.27%
========================================
Files 302 302
Lines 22868 22870 +2
========================================
+ Hits 22703 22705 +2
Misses 165 165 ☔ View full report in Codecov by Sentry. |
valentinsulzer
approved these changes
Nov 12, 2024
pkalbhor
pushed a commit
to pkalbhor/PyBaMM
that referenced
this pull request
Nov 15, 2024
* Error message fix * Fix logging error * Remove blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple minor bug fixes before the release
Fixes #4580
Fixes #4578
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: