Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main and develop #4410

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Sync main and develop #4410

merged 3 commits into from
Sep 3, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Sep 3, 2024

Description

Sync PR for the changelog

@kratman kratman merged commit 2511707 into develop Sep 3, 2024
32 of 35 checks passed
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 99.63235% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.42%. Comparing base (91c9744) to head (0e50894).
Report is 296 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/citations.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4410      +/-   ##
===========================================
- Coverage    99.45%   99.42%   -0.04%     
===========================================
  Files          288      292       +4     
  Lines        22092    22215     +123     
===========================================
+ Hits         21972    22087     +115     
- Misses         120      128       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants