Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new Input/Output model #5

Closed
lukehoban opened this issue Feb 7, 2018 · 0 comments · Fixed by #8
Closed

Update to new Input/Output model #5

lukehoban opened this issue Feb 7, 2018 · 0 comments · Fixed by #8
Assignees
@CyrusNajmabadi
Milestone
0.10

Comments

@lukehoban
Copy link
Member

Adopt the changes in pulumi{-terraform} to move from Computed to Input/Output.
@lukehoban lukehoban self-assigned this Feb 7, 2018
@lukehoban lukehoban added this to the 0.10 milestone Feb 7, 2018
@lukehoban lukehoban assigned CyrusNajmabadi and unassigned lukehoban Feb 8, 2018
@lukehoban lukehoban mentioned this issue Feb 8, 2018
Merged
lukehoban added a commit that referenced this issue Nov 18, 2018
@lukehoban
Allow more flexible chart references
3088a11 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
lukehoban added a commit that referenced this issue Nov 19, 2018
@lukehoban
Allow more flexible chart references
01bdd26 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
None yet
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

Update deps to 0.10-rc1 pulumi/pulumi-kubernetes
2 participants
@lukehoban @CyrusNajmabadi