Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guestbook example #4

Closed
lukehoban opened this issue Feb 6, 2018 · 1 comment
Closed

Guestbook example #4

lukehoban opened this issue Feb 6, 2018 · 1 comment
Assignees
@lukehoban
Labels
area/examples
Milestone
0.11

Comments

@lukehoban
Copy link
Member

Add an implementation of the Guestbook example to this repo.
@lukehoban lukehoban modified the milestones: 0.12, 0.11 Feb 6, 2018
@lukehoban
Copy link
Member Author

Moving to 0.11 - as I think having this example working is key to believing this provider is in "good" shape.

@lukehoban lukehoban mentioned this issue Feb 13, 2018
Merged
@joeduffy joeduffy assigned lukehoban and unassigned subhabh Feb 13, 2018
lukehoban added a commit that referenced this issue Nov 18, 2018
@lukehoban
Allow more flexible chart references
3088a11 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
lukehoban added a commit that referenced this issue Nov 19, 2018
@lukehoban
Allow more flexible chart references
01bdd26 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehoban lukehoban

Labels
area/examples
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
3 participants
@lukehoban @joeduffy @subhabh