Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype a Kubernetes resource provider #1

Closed
joeduffy opened this issue Jan 9, 2018 · 1 comment
Closed

Prototype a Kubernetes resource provider #1

joeduffy opened this issue Jan 9, 2018 · 1 comment
Assignees
@subhabh
Milestone
0.10

Comments

@joeduffy
Copy link
Member

joeduffy commented Jan 9, 2018

No description provided.

@joeduffy joeduffy added this to the 0.10 milestone Jan 9, 2018
@lukehoban
Copy link
Member

This was done with #2.

lukehoban added a commit that referenced this issue Nov 18, 2018
@lukehoban
Allow more flexible chart references
3088a11 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
lukehoban added a commit that referenced this issue Nov 19, 2018
@lukehoban
Allow more flexible chart references
01bdd26 
Allows the `chart` input argument to be used in more of the same ways allowed as argument to `helm install`.  Makes `repo` optional to allow chart to be provided in forms that require fully qualified references.  Actually expose the `fetchOpts` argument so that `--repo` (and other customerizations to fetch) can be passed.  Adds some additional test coverage.

All of the following now work:

// #1
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// #2
repo: "stable",
chart: "nginx-lego",

// #3
chart: "stable/nginx-lego",

// #4
chart: "stable/nginx-lego",
version: "0.3.1"

// #5
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #6
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// #7
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",

Fixes #229.
Fixes #257.
@MitchellGerdisch MitchellGerdisch mentioned this issue May 28, 2021
Closed
@lkt82 lkt82 mentioned this issue Jun 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subhabh subhabh

Labels
None yet
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
3 participants
@lukehoban @joeduffy @subhabh