Upgrade to v4.50.0 with submodule patching #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveklak
approved these changes
Dec 6, 2022
thomas11
approved these changes
Dec 8, 2022
- Ignore dirty submodule from git diff to avoid local changes flagging in CI
- Make it a little less noisy
- Allow a default path to be set up for all providers. - Add init_upstream and update_upstream makefile target.
- Update tf-patcher tool. - Copy replacements and domains out of the fork. - Add warning to `update_upstream` target as it's not finished yet. - Run check as part of `patch_upstream` target.
danielrbradley
force-pushed
the
submodule-patching
branch
from
ee97cd3 to
46e48d7
Compare
danielrbradley
changed the title
thomas11
approved these changes
Jan 20, 2023
Include output so we can see what's happening more clearly.
lblackstone
approved these changes
Jan 20, 2023
Does the PR have any schema changes?Found 1 breaking change: New resources:
New functions:
|
thomas11
added a commit
to pulumi/action-test-provider-downstream
that referenced
this pull request
Jan 30, 2023
Necessary since pulumi/pulumi-aws#2247
abhinav
added a commit
to pulumi/action-test-provider-downstream
that referenced
this pull request
Feb 8, 2023
Clones the downstream repository with `--recurse-submodules` which will check out all submodules in the repository after cloning. This is necessary because pulumi-aws now uses submodules (pulumi/pulumi-aws#2247). Resolves pulumi/pulumi#12115 Resolves #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust process to apply replacements in the local submodule checkout. This should make the process a little slicker so we're not committing tooling into the fork.