Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone with submodules #16

Closed
wants to merge 5 commits into from
Closed

Clone with submodules #16

wants to merge 5 commits into from

Conversation

thomas11
Copy link

Necessary since pulumi/pulumi-aws#2247 to fix failures like this one.

@iwahbe
Copy link
Member

iwahbe commented Jan 30, 2023

It looks like we're still missing a step here. Our integration tests are saying:

github.com/frankban/quicktest: github.com/hashicorp/[email protected] (replaced by ../upstream): reading ../upstream/go.mod: open /home/runner/work/action-test-provider-downstream/pulumi-aws/upstream/go.mod: no such file or directory

@thomas11 thomas11 linked an issue Jan 30, 2023 that may be closed by this pull request
@iwahbe
Copy link
Member

iwahbe commented Jan 31, 2023

The current error message is:

/usr/bin/git submodule update --init
Submodule 'terraform-provider-aws' ([email protected]:pulumi/terraform-provider-aws.git) registered for path 'upstream'
Cloning into '/home/runner/work/action-test-provider-downstream/pulumi-aws/upstream'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I encountered this on my personal machine. The solution was to generate a key pair and inform GitHub about the public key, then configure git to use the private key when speaking to GitHub. I'm not sure what the recommended way to access git from CI is, but it's at least a place to start.

@thomas11
Copy link
Author

I encountered this on my personal machine. The solution was to generate a key pair and inform GitHub about the public key, then configure git to use the private key when speaking to GitHub. I'm not sure what the recommended way to access git from CI is, but it's at least a place to start.

I think the easier way is to just switch the submodule config to HTTPS auth which we use everywhere else. Discussing with Daniel in #aws.

@thomas11
Copy link
Author

I encountered this on my personal machine. The solution was to generate a key pair and inform GitHub about the public key, then configure git to use the private key when speaking to GitHub. I'm not sure what the recommended way to access git from CI is, but it's at least a place to start.

I think the easier way is to just switch the submodule config to HTTPS auth which we use everywhere else. Discussing with Daniel in #aws.

pulumi/pulumi-aws#2338

src/main.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer works with pulumi-aws due to submodules.
3 participants